Skip to content

Commit 11a2834

Browse files
Gayathri Srividya RajavarapuGayathri Srividya Rajavarapu
authored andcommitted
fix: remove unused type: ignore comments flagged by mypy
1 parent b2a2e46 commit 11a2834

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

‎tests/catalog/test_rest.py‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3193,7 +3193,7 @@ def test_rest_catalog_with_basic_auth_as_json_string(rest_mock: Mocker) -> None:
31933193
"uri": TEST_URI,
31943194
"auth": json.dumps(auth_dict),
31953195
}
3196-
catalog = RestCatalog("rest", **catalog_properties) # type: ignore
3196+
catalog = RestCatalog("rest", **catalog_properties)
31973197
assert catalog.uri == TEST_URI
31983198

31993199
encoded_user_pass = base64.b64encode(b"one:two").decode()
@@ -3231,14 +3231,14 @@ def test_rest_catalog_with_oauth2_auth_as_json_string(requests_mock: Mocker) ->
32313231
"uri": TEST_URI,
32323232
"auth": json.dumps(auth_dict),
32333233
}
3234-
catalog = RestCatalog("rest", **catalog_properties) # type: ignore
3234+
catalog = RestCatalog("rest", **catalog_properties)
32353235
assert catalog.uri == TEST_URI
32363236

32373237

32383238
def test_rest_catalog_with_invalid_json_auth_string() -> None:
32393239
"""An auth value that is a string but not valid JSON should raise a descriptive ValueError."""
32403240
with pytest.raises(ValueError, match="Failed to parse auth configuration as JSON"):
3241-
RestCatalog("rest", uri=TEST_URI, auth="not-valid-json") # type: ignore
3241+
RestCatalog("rest", uri=TEST_URI, auth="not-valid-json")
32423242

32433243

32443244
def test_rest_catalog_with_basic_auth_flat_properties(rest_mock: Mocker) -> None:
@@ -3261,7 +3261,7 @@ def test_rest_catalog_with_basic_auth_flat_properties(rest_mock: Mocker) -> None
32613261
"auth.basic.username": "one",
32623262
"auth.basic.password": "two",
32633263
}
3264-
catalog = RestCatalog("rest", **catalog_properties) # type: ignore
3264+
catalog = RestCatalog("rest", **catalog_properties)
32653265
assert catalog.uri == TEST_URI
32663266

32673267
encoded_user_pass = base64.b64encode(b"one:two").decode()
@@ -3297,5 +3297,5 @@ def test_rest_catalog_with_oauth2_auth_flat_properties(requests_mock: Mocker) ->
32973297
"auth.oauth2.client-secret": "some_client_secret",
32983298
"auth.oauth2.token-url": f"{TEST_URI}oauth2/token",
32993299
}
3300-
catalog = RestCatalog("rest", **catalog_properties) # type: ignore
3300+
catalog = RestCatalog("rest", **catalog_properties)
33013301
assert catalog.uri == TEST_URI

0 commit comments

Comments
 (0)