Skip to content

Commit 21c577f

Browse files
committed
Infra: Rename the object store service to object-store
Feedback from @kevinjqliu
1 parent e118b00 commit 21c577f

5 files changed

Lines changed: 26 additions & 26 deletions

File tree

‎dev/docker-compose-integration.yml‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ services:
2828
depends_on:
2929
- rest
3030
- hive
31-
- rustfs
31+
- object-store
3232
ports:
3333
- 15002:15002 # Spark Connect
3434
- 4040:4040 # Spark UI
@@ -39,7 +39,7 @@ services:
3939
links:
4040
- rest:rest
4141
- hive:hive
42-
- rustfs:rustfs
42+
- object-store:object-store
4343
healthcheck:
4444
test: ["CMD", "sh", "-c", "netstat -an | grep 15002 | grep LISTEN"]
4545
interval: 30s
@@ -59,15 +59,15 @@ services:
5959
- AWS_REGION=us-east-1
6060
- CATALOG_WAREHOUSE=s3://warehouse/
6161
- CATALOG_IO__IMPL=org.apache.iceberg.aws.s3.S3FileIO
62-
- CATALOG_S3_ENDPOINT=http://rustfs:9000
62+
- CATALOG_S3_ENDPOINT=http://object-store:9000
6363
- CATALOG_JDBC_STRICT__MODE=true
64-
rustfs:
64+
object-store:
6565
image: rustfs/rustfs:1.0.0-rc.5
66-
container_name: pyiceberg-rustfs
66+
container_name: pyiceberg-object-store
6767
networks:
6868
iceberg_net:
6969
aliases:
70-
- warehouse.rustfs
70+
- warehouse.object-store
7171
ports:
7272
- 9001:9001
7373
- 9000:9000
@@ -78,9 +78,9 @@ services:
7878
- RUSTFS_ADDRESS=:9000
7979
- RUSTFS_CONSOLE_ENABLE=true
8080
- RUSTFS_CONSOLE_ADDRESS=:9001
81-
# Resolves virtual-hosted-style `warehouse.rustfs` to the warehouse bucket.
82-
# The port is required until rustfs/rustfs#7051 ships.
83-
- RUSTFS_SERVER_DOMAINS=rustfs:9000
81+
# Resolves virtual-hosted-style `warehouse.object-store` to the warehouse
82+
# bucket. The port is required until rustfs/rustfs#7051 ships.
83+
- RUSTFS_SERVER_DOMAINS=object-store:9000
8484
healthcheck:
8585
test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health"]
8686
interval: 5s
@@ -93,17 +93,17 @@ services:
9393
networks:
9494
iceberg_net:
9595
depends_on:
96-
rustfs:
96+
object-store:
9797
condition: service_healthy
9898
environment:
9999
- AWS_ACCESS_KEY_ID=admin
100100
- AWS_SECRET_ACCESS_KEY=password
101101
- AWS_REGION=us-east-1
102-
- AWS_ENDPOINT_URL=http://rustfs:9000
102+
- AWS_ENDPOINT_URL=http://object-store:9000
103103
entrypoint: /bin/sh
104104
command:
105105
- -c
106-
- "aws s3 mb s3://warehouse"
106+
- "aws s3 rb s3://warehouse --force 2>/dev/null; aws s3 mb s3://warehouse"
107107
hive:
108108
image: pyiceberg-hive:latest
109109
build:

‎dev/docker-compose.yml‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -16,36 +16,36 @@
1616
# under the License.
1717

1818
services:
19-
rustfs:
19+
object-store:
2020
image: rustfs/rustfs:1.0.0-rc.5
21-
container_name: pyiceberg-rustfs
21+
container_name: pyiceberg-object-store
22+
ports:
23+
- 9001:9001
24+
- 9000:9000
2225
environment:
2326
- RUSTFS_ACCESS_KEY=admin
2427
- RUSTFS_SECRET_KEY=password
2528
- RUSTFS_VOLUMES=/data
2629
- RUSTFS_ADDRESS=:9000
2730
- RUSTFS_CONSOLE_ENABLE=true
2831
- RUSTFS_CONSOLE_ADDRESS=:9001
29-
ports:
30-
- 9001:9001
31-
- 9000:9000
3232
healthcheck:
3333
test: ["CMD-SHELL", "curl --fail http://127.0.0.1:9000/health"]
3434
interval: 5s
3535
timeout: 5s
3636
retries: 10
3737
start_period: 5s
3838
aws-cli:
39-
depends_on:
40-
rustfs:
41-
condition: service_healthy
4239
image: amazon/aws-cli:2.36.40
4340
container_name: pyiceberg-aws-cli
41+
depends_on:
42+
object-store:
43+
condition: service_healthy
4444
environment:
4545
- AWS_ACCESS_KEY_ID=admin
4646
- AWS_SECRET_ACCESS_KEY=password
4747
- AWS_REGION=us-east-1
48-
- AWS_ENDPOINT_URL=http://rustfs:9000
48+
- AWS_ENDPOINT_URL=http://object-store:9000
4949
entrypoint: /bin/sh
5050
command:
5151
- -c

‎dev/hive/core-site.xml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
</property>
3333
<property>
3434
<name>fs.s3a.endpoint</name>
35-
<value>http://rustfs:9000</value>
35+
<value>http://object-store:9000</value>
3636
</property>
3737
<property>
3838
<name>fs.s3a.access.key</name>

‎dev/run-s3.sh‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020

2121
set -ex
2222

23-
if [ $(docker ps -q --filter "name=pyiceberg-rustfs" --filter "health=healthy" ) ]; then
23+
if [ $(docker ps -q --filter "name=pyiceberg-object-store" --filter "health=healthy" ) ]; then
2424
echo "S3 backend running"
2525
else
2626
docker compose -f dev/docker-compose.yml kill

‎dev/spark/spark-defaults.conf‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ spark.sql.catalog.rest.type rest
2323
spark.sql.catalog.rest.uri http://rest:8181
2424
spark.sql.catalog.rest.io-impl org.apache.iceberg.aws.s3.S3FileIO
2525
spark.sql.catalog.rest.warehouse s3://warehouse/rest/
26-
spark.sql.catalog.rest.s3.endpoint http://rustfs:9000
26+
spark.sql.catalog.rest.s3.endpoint http://object-store:9000
2727
spark.sql.catalog.rest.cache-enabled false
2828

2929
# Configure Iceberg Hive catalog
@@ -32,13 +32,13 @@ spark.sql.catalog.hive.type hive
3232
spark.sql.catalog.hive.uri thrift://hive:9083
3333
spark.sql.catalog.hive.io-impl org.apache.iceberg.aws.s3.S3FileIO
3434
spark.sql.catalog.hive.warehouse s3://warehouse/hive/
35-
spark.sql.catalog.hive.s3.endpoint http://rustfs:9000
35+
spark.sql.catalog.hive.s3.endpoint http://object-store:9000
3636

3737
# Configure Spark's default session catalog (spark_catalog) to use Iceberg backed by the Hive Metastore
3838
spark.sql.catalog.spark_catalog org.apache.iceberg.spark.SparkSessionCatalog
3939
spark.sql.catalog.spark_catalog.type hive
4040
spark.sql.catalog.spark_catalog.uri thrift://hive:9083
41-
spark.hadoop.fs.s3a.endpoint http://rustfs:9000
41+
spark.hadoop.fs.s3a.endpoint http://object-store:9000
4242
spark.sql.catalogImplementation hive
4343
spark.sql.warehouse.dir s3a://warehouse/hive/
4444

0 commit comments

Comments
 (0)