Skip to content

Commit 4b586f7

Browse files
committed
Fix mypy type narrowing in sequence number preservation test
1 parent 59d98ff commit 4b586f7

1 file changed

Lines changed: 12 additions & 12 deletions

File tree

‎tests/table/test_rewrite_manifests.py‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -79,26 +79,26 @@ def test_rewrite_manifests_merges_data_manifests(catalog: Catalog) -> None:
7979
assert snapshot.summary["total-records"] == "9"
8080

8181

82+
def _sequence_numbers_by_file(table: Table) -> dict[str, int]:
83+
result: dict[str, int] = {}
84+
for manifest in _data_manifests(table):
85+
for entry in manifest.fetch_manifest_entry(table.io, discard_deleted=True):
86+
assert entry.sequence_number is not None
87+
result[entry.data_file.file_path] = entry.sequence_number
88+
return result
89+
90+
8291
def test_rewrite_manifests_preserves_sequence_numbers(catalog: Catalog) -> None:
8392
table = _create_table_with_appends(catalog, appends=3)
84-
entries_before = {
85-
entry.data_file.file_path: entry.sequence_number
86-
for manifest in _data_manifests(table)
87-
for entry in manifest.fetch_manifest_entry(table.io, discard_deleted=True)
88-
}
93+
entries_before = _sequence_numbers_by_file(table)
8994

9095
table.maintenance.rewrite_manifests().commit()
9196

9297
table = catalog.load_table("default.test_rewrite")
93-
manifests = _data_manifests(table)
94-
entries_after = {
95-
entry.data_file.file_path: entry.sequence_number
96-
for manifest in manifests
97-
for entry in manifest.fetch_manifest_entry(table.io, discard_deleted=True)
98-
}
98+
entries_after = _sequence_numbers_by_file(table)
9999
assert entries_after == entries_before
100100
# the merged manifest keeps the min sequence number of its entries
101-
assert manifests[0].min_sequence_number == min(entries_before.values())
101+
assert _data_manifests(table)[0].min_sequence_number == min(entries_before.values())
102102

103103

104104
def test_rewrite_manifests_single_manifest_is_noop(catalog: Catalog) -> None:

0 commit comments

Comments
 (0)