Skip to content

Commit 6c3c2f3

Browse files
authored
Make scan_plan_helper private (#3541) (#3553)
scan_plan_helper is an internal helper for local scan planning, not a public extension point. Rename it to _scan_plan_helper to reflect its intended visibility and update its only caller in inspect.py. The method was introduced recently in d99936a and has not been part of any released public API, so no deprecation shim is required. Fixes: #3541 <!-- Thanks for opening a pull request! --> <!-- In the case this PR will resolve an issue, please replace ${GITHUB_ISSUE_ID} below with the actual Github issue id. --> <!-- Closes #${GITHUB_ISSUE_ID} --> # Rationale for this change ## Are these changes tested? ## Are there any user-facing changes? <!-- In the case of user-facing changes, please add the changelog label. -->
1 parent 5be1595 commit 6c3c2f3

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

‎pyiceberg/table/__init__.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2224,7 +2224,7 @@ def _manifest_planner(self) -> ManifestGroupPlanner:
22242224
def partition_filters(self) -> KeyDefaultDict[int, BooleanExpression]:
22252225
return self._manifest_planner.partition_filters
22262226

2227-
def scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
2227+
def _scan_plan_helper(self) -> Iterator[list[ManifestEntry]]:
22282228
"""Filter and return manifest entries based on partition and metrics evaluators.
22292229
22302230
Returns:

‎pyiceberg/table/inspect.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -311,7 +311,7 @@ def partitions(
311311

312312
partitions_map: dict[tuple[str, Any], Any] = {}
313313

314-
for entry in itertools.chain.from_iterable(scan.scan_plan_helper()):
314+
for entry in itertools.chain.from_iterable(scan._scan_plan_helper()):
315315
partition = entry.data_file.partition
316316
partition_record_dict = {
317317
field.name: partition[pos] for pos, field in enumerate(self.tbl.metadata.specs()[entry.data_file.spec_id].fields)

0 commit comments

Comments
 (0)