Skip to content

Commit 7c5d9ff

Browse files
kevinjqliuCopilot
andcommitted
Clarify versioned DataFile test setup
Keep the canonical DataFile name distinct from the explicit v1 record and order version selection first. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 1b3a628 commit 7c5d9ff

1 file changed

Lines changed: 4 additions & 4 deletions

File tree

‎tests/avro/test_file.py‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -250,13 +250,13 @@ def test_write_manifest_entry_with_fastavro_read_with_iceberg(format_version: Ta
250250
"sort_order_id": 4,
251251
"spec_id": 3,
252252
}
253-
data_file_v2 = DataFile.from_args(content=DataFileContent.DATA, **common_data_file_args) # type: ignore
254-
assert data_file_v2.spec_id == 3
253+
data_file = DataFile.from_args(content=DataFileContent.DATA, **common_data_file_args) # type: ignore
254+
assert data_file.spec_id == 3
255255

256256
entry = ManifestEntry.from_args(
257257
status=ManifestEntryStatus.ADDED,
258258
snapshot_id=8638475580105682862,
259-
data_file=data_file_v2,
259+
data_file=data_file,
260260
)
261261

262262
with TemporaryDirectory() as tmpdir:
@@ -289,8 +289,8 @@ def test_write_manifest_entry_with_fastavro_read_with_iceberg(format_version: Ta
289289

290290
if format_version == 1:
291291
data_file_v1 = DataFile.from_args(
292-
block_size_in_bytes=DEFAULT_BLOCK_SIZE,
293292
_table_format_version=format_version,
293+
block_size_in_bytes=DEFAULT_BLOCK_SIZE,
294294
**common_data_file_args, # type: ignore
295295
)
296296

0 commit comments

Comments
 (0)