Skip to content

Commit c541c98

Browse files
committed
Address review: fix deprecation versions and trim comment
1 parent 563aa3c commit c541c98

1 file changed

Lines changed: 3 additions & 4 deletions

File tree

‎pyiceberg/table/__init__.py‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,7 @@
125125

126126
ALWAYS_TRUE = AlwaysTrue()
127127
DOWNCAST_NS_TIMESTAMP_TO_US = "downcast-ns-timestamp-to-us"
128-
# Deprecated: use DOWNCAST_NS_TIMESTAMP_TO_US. The old key said "on-write" but the
129-
# config also controls read-path downcasting, so the name was misleading.
128+
# Deprecated: use DOWNCAST_NS_TIMESTAMP_TO_US
130129
DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE = "downcast-ns-timestamp-to-us-on-write"
131130

132131

@@ -146,8 +145,8 @@ def get_downcast_ns_timestamp_to_us() -> bool:
146145
legacy = config.get_bool(DOWNCAST_NS_TIMESTAMP_TO_US_ON_WRITE)
147146
if legacy is not None:
148147
deprecation_message(
149-
deprecated_in="0.9.0",
150-
removed_in="0.10.0",
148+
deprecated_in="0.12.0",
149+
removed_in="0.13.0",
151150
help_message="Config key 'downcast-ns-timestamp-to-us-on-write' is deprecated. "
152151
"Use 'downcast-ns-timestamp-to-us' (env: PYICEBERG_DOWNCAST_NS_TIMESTAMP_TO_US) instead.",
153152
)

0 commit comments

Comments
 (0)