fix(i18n): tighten producer code boundaries

Generated-by: OpenCode

Author: orangeCatDeveloper

apps/desktop/src/main/__tests__/oauth-result-copy.test.ts

@@ -23,7 +23,10 @@ import test from "node:test";
 // `node --test "dist/main/**/*.test.js"`, and settings-provider-copy is a pure
 // copy module (no react), so it is safe to exercise from node. Same precedent
 // as permission-center-copy.test.ts.
-import { subscriptionResultMessage } from "../../renderer/features/connection-settings/index.js";
+import {
+  connectionTestFailureMessage,
+  subscriptionResultMessage,
+} from "../../renderer/features/connection-settings/index.js";
 
 test("renders a coded Copilot import failure per locale, ignoring its machine message", () => {
   const result = { code: "copilot_subscription_unavailable", message: "copilot_subscription_unavailable" };
@@ -42,3 +45,16 @@ test("falls back to catalog copy for an unknown code instead of the raw message"
   assert.equal(subscriptionResultMessage(result, "fallback", "en"), "fallback");
   assert.equal(subscriptionResultMessage(result, "fallback", "zh"), "fallback");
 });
+
+test("renders provider rate limits consistently from the stable status code", () => {
+  const result = { ok: false, statusCode: 429, errorClass: "provider_unavailable" } as const;
+  const troubleshooting = { auth: "auth", recheck: "recheck" };
+  assert.equal(
+    connectionTestFailureMessage(result, troubleshooting, "zh"),
+    "当前账号或模型服务触发速率限制，请稍后重试。",
+  );
+  assert.equal(
+    connectionTestFailureMessage(result, troubleshooting, "en"),
+    "This account or model service is rate-limited. Try again later.",
+  );
+});

apps/desktop/src/main/__tests__/settings-test-result-copy.test.ts

@@ -37,13 +37,3 @@ test("missing proxy credentials have actionable bilingual copy", () => {
     "Proxy authentication is enabled. Enter a proxy password before testing.",
   );
 });
-
-test("renders the disabled-direct proxy code per locale", () => {
-  const result = { ok: true, code: "proxy_disabled_direct", message: "direct" } as never;
-  assert.equal(settingsTestResultMessage(result, "zh"), "代理未启用，当前会直接连接。");
-  assert.equal(
-    settingsTestResultMessage(result, "en"),
-    "The proxy is disabled; connections go direct.",
-  );
-});
-

apps/desktop/src/main/capability-snapshot.ts

@@ -19,7 +19,6 @@
 
 import { Notification, systemPreferences } from 'electron';
 import { BOT_PROVIDERS, type BotProvider } from '@maka/core/bot-chat-settings';
-import { redactSecrets } from '@maka/core/redaction';
 import {
   deriveCapabilityReadiness,
   runtimeProbeFromBotReadiness,
@@ -140,7 +139,7 @@ function computerUseCapability(
     feature: {
       state: artifactAvailable ? 'enabled' : 'not_available',
       source: 'runtime',
-      reason: computerUseCapabilityReason(input),
+      reason: input === undefined || input.backendId === 'none' ? 'cu_artifact_missing' : 'cu_backend_status',
     },
     requiredPermissions: [
       { id: 'accessibility', required: true, status: permissions.accessibility.status },
@@ -160,22 +159,6 @@ function computerUseCapability(
   });
 }
 
-// The presenter composes the full 'cu_backend_status' sentence from data the
-// same snapshot already carries (required-permission statuses and the runtime
-// probe state), so the reason stays a bare code. The backend name is not
-// threaded through: CU_BACKEND_IDS is ['maka-cu'] today.
-function computerUseCapabilityReason(
-  input: {
-    backendId: CuBackendId | 'none';
-    health: ReturnType<typeof computerUseServiceHealth>;
-  } | undefined,
-): string {
-  if (input === undefined || input.backendId === 'none') {
-    return 'cu_artifact_missing';
-  }
-  return 'cu_backend_status';
-}
-
 function staticCapability(input: {
   id: CapabilitySnapshot['id'];
   label: string;
@@ -268,8 +251,8 @@ function accessibilitySnapshot(now: number, platform: NodeJS.Platform): OsPermis
       canOpenSettings: true,
       canRequest: false,
     };
-  } catch (error) {
-    return unknownPermission('accessibility', now, error, true);
+  } catch {
+    return unknownPermission('accessibility', now, true);
   }
 }
 
@@ -292,8 +275,8 @@ function mediaPermissionSnapshot(
       checkedAt: now,
       ...actions,
     };
-  } catch (error) {
-    return unknownPermission(id, now, error, platform === 'darwin');
+  } catch {
+    return unknownPermission(id, now, platform === 'darwin');
   }
 }
 
@@ -349,7 +332,6 @@ function unsupportedPermission(
 function unknownPermission(
   id: OsPermissionId,
   now: number,
-  error: unknown,
   canOpenSettings: boolean,
 ): OsPermissionSnapshot {
   return {
@@ -358,10 +340,6 @@ function unknownPermission(
     source: 'electron',
     checkedAt: now,
     reason: 'permission_probe_failed',
-    // Raw probe error text passes through as diagnostic detail, redacted at
-    // the producer so every presenter can render it verbatim beside the
-    // localized 'permission_probe_failed' copy.
-    ...(error instanceof Error && error.message ? { detail: redactSecrets(error.message) } : {}),
     canOpenSettings,
     canRequest: false,
   };

apps/desktop/src/main/computer-use-host.ts

@@ -34,6 +34,7 @@ import {
   selectComputerUseBackend,
   type SelectedComputerUseBackend,
 } from '@maka/computer-use';
+import type { CapabilityReasonCode } from '@maka/core/capabilities';
 import type { CuOverlayHook } from '@maka/runtime/computer-use-types';
 
 export interface ComputerUseHostState {
@@ -147,7 +148,7 @@ export function computerUseServiceHealth(
   state: MakaCuServiceSnapshot | undefined,
 ): {
   state: 'not_available' | 'not_run' | 'healthy' | 'degraded';
-  reason: string;
+  reason: CapabilityReasonCode;
 } {
   if (backendId === 'none' || !state) {
     return { state: 'not_available', reason: 'cu_executor_undistributable' };

apps/desktop/src/renderer/features/connection-settings/provider-panel-shared.ts

@@ -69,7 +69,6 @@ export function connectionTestFailureFallback(
   locale: UiLocale,
 ): string {
   const shared = getProviderSettingsCopy(locale).shared;
-  if (result.errorCode === 'oauth_rate_limited') return shared.oauthRateLimit;
   if (result.statusCode === 429) return shared.rateLimit;
   if (result.errorClass === 'timeout') return shared.timeout;
   if (result.errorClass === 'auth' || result.statusCode === 401 || result.statusCode === 403) {
@@ -88,9 +87,7 @@ export function connectionTestFailureMessage(
   locale: UiLocale,
 ): string {
   const fallback = connectionTestFailureFallback(result, copy, locale);
-  // A coded result already resolved to specific per-locale copy above; the
-  // errorMessage is only its machine-readable twin.
-  if (result.errorCode || !result.errorMessage) return fallback;
+  if (!result.errorMessage) return fallback;
   return locale === 'zh'
     ? generalizedErrorMessageChinese(new Error(result.errorMessage), fallback)
     : generalizedErrorMessage(new Error(result.errorMessage), fallback);

apps/desktop/src/renderer/features/connection-settings/settings-provider-copy.ts

@@ -158,7 +158,7 @@ const zhCopy = {
     modelKeyAria: (name: string) => `${name} 模型密钥`,
   },
   shared: {
-    actionFallback: '模型连接服务暂时不可用，请稍后重试。', rateLimit: '当前账号或模型服务触发速率限制，请稍后重试。', oauthRateLimit: 'OAuth 已登录，但当前账号或 provider 正在 rate limit。请稍后重试，或先切换到其它可用模型。',
+    actionFallback: '模型连接服务暂时不可用，请稍后重试。', rateLimit: '当前账号或模型服务触发速率限制，请稍后重试。',
     timeout: '请求超时，请检查网络或代理后重试。', unavailable: '模型服务暂时不可用，请稍后重试。',
     network: '网络错误，请检查服务地址或代理设置后重试。', statusUnavailable: '连接测试状态暂时无法显示，请重新测试。',
     categories: { oauth: 'OAuth', domestic: '国内', overseas: '海外', local: '本地', custom: 'Custom' },
@@ -332,7 +332,7 @@ const enCopy: ProviderSettingsCopy = {
     modelKeyAria: (name: string) => `${name} model key`,
   },
   shared: {
-    actionFallback: 'The model connection service is temporarily unavailable. Try again later.', rateLimit: 'This account or model service is rate-limited. Try again later.', oauthRateLimit: 'Signed in, but the account or provider is currently rate limited. Retry later or switch to another available model.',
+    actionFallback: 'The model connection service is temporarily unavailable. Try again later.', rateLimit: 'This account or model service is rate-limited. Try again later.',
     timeout: 'The request timed out. Check the network or proxy and try again.', unavailable: 'The model service is temporarily unavailable. Try again later.',
     network: 'Network error. Check the service URL or proxy settings and try again.', statusUnavailable: 'The connection test status is temporarily unavailable. Test again.',
     categories: { oauth: 'OAuth', domestic: 'China', overseas: 'Global', local: 'Local', custom: 'Custom' },

apps/desktop/src/renderer/locales/settings-test-result-copy.ts

@@ -28,7 +28,6 @@ type SettingsTestResultCopy = {
       location: string | undefined,
     ) => string;
     disabled: string;
-    disabledDirect: string;
     configurationMissing: string;
     credentialMissing: string;
     timeout: string;
@@ -50,7 +49,6 @@ const COPY = {
       reachable: (endpoint, location) =>
         ["代理配置有效", endpoint, location].filter(Boolean).join(" · "),
       disabled: "请先启用代理服务器，再进行测试。",
-      disabledDirect: "代理未启用，当前会直接连接。",
       configurationMissing: "请填写代理服务器地址和端口后再测试。",
       credentialMissing: "代理认证已开启，请输入代理密码后再测试。",
       timeout: "代理测试超时，请检查代理服务是否可达。",
@@ -78,7 +76,6 @@ const COPY = {
           .filter(Boolean)
           .join(" · "),
       disabled: "Enable the proxy server before testing it.",
-      disabledDirect: "The proxy is disabled; connections go direct.",
       configurationMissing: "Enter a proxy host and port before testing it.",
       credentialMissing:
         "Proxy authentication is enabled. Enter a proxy password before testing.",
@@ -120,8 +117,6 @@ export function settingsTestResultMessage(
       );
     case "proxy_disabled":
       return copy.proxy.disabled;
-    case "proxy_disabled_direct":
-      return copy.proxy.disabledDirect;
     case "proxy_configuration_missing":
       return copy.proxy.configurationMissing;
     case "proxy_credential_missing":

apps/desktop/src/renderer/settings/permission-center-page.tsx

@@ -744,10 +744,7 @@ function osPermissionReasonText(
       ? copy.reasons[snapshot.reason]
       : copy.reasonFallback
     : undefined;
-  // `detail` is redacted probe diagnostics from the producer and renders
-  // verbatim beside the copy.
-  if (!text) return snapshot.detail;
-  return snapshot.detail ? `${text} · ${snapshot.detail}` : text;
+  return text;
 }
 
 function featureTone(state: CapabilitySnapshot['feature']['state']): StatusSemantic {

packages/core/src/capabilities.ts

@@ -150,8 +150,6 @@ export interface OsPermissionSnapshot {
   source: 'electron' | 'platform' | 'static';
   checkedAt: number;
   reason?: string;
-  /** Raw diagnostic pass-through (external error text), rendered verbatim. */
-  detail?: string;
   canOpenSettings: boolean;
   canRequest: boolean;
 }

packages/core/src/llm-connections.ts

@@ -531,8 +531,6 @@ export interface ConnectionTestResult {
   errorMessage?: string;
   statusCode?: number;
   errorClass?: ConnectionTestErrorClass;
-  /** Stable machine code the presenter maps to per-locale copy. */
-  errorCode?: 'oauth_rate_limited';
 }
 
 /**