From 7557a6c1c52ebe053bc73236cf631813bea1e62d Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Thu, 2 Jul 2026 16:36:22 +0000 Subject: [PATCH 1/2] Extract Pattern.compile() to static final field --- .../java/org/apache/maven/shared/archiver/MavenArchiver.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java index cbab812..0978fdc 100644 --- a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java +++ b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java @@ -99,6 +99,9 @@ public class MavenArchiver { private static final List ARTIFACT_EXPRESSION_PREFIXES; + private static final Pattern SPECIFICATION_VERSION_PATTERN = + Pattern.compile("([0-9]+\\.[0-9]+)(.*?)"); + static { List artifactExpressionPrefixes = new ArrayList<>(); artifactExpressionPrefixes.add("artifact."); @@ -413,7 +416,7 @@ private void handleSpecificationEntries(Project project, Map ent m, entries, "Specification-Title", project.getModel().getName()); String version = project.getPomArtifact().getVersion().toString(); - Matcher matcher = Pattern.compile("([0-9]+\\.[0-9]+)(.*?)").matcher(version); + Matcher matcher = SPECIFICATION_VERSION_PATTERN.matcher(version); if (matcher.matches()) { String specVersion = matcher.group(1); addManifestAttribute(m, entries, "Specification-Version", specVersion); From 3acd3c49b7312cffc3fe46057335a9414a67179a Mon Sep 17 00:00:00 2001 From: Elliotte Rusty Harold Date: Thu, 2 Jul 2026 16:39:43 +0000 Subject: [PATCH 2/2] Apply spotless formatting --- .../java/org/apache/maven/shared/archiver/MavenArchiver.java | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java index 0978fdc..9f65021 100644 --- a/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java +++ b/src/main/java/org/apache/maven/shared/archiver/MavenArchiver.java @@ -99,8 +99,7 @@ public class MavenArchiver { private static final List ARTIFACT_EXPRESSION_PREFIXES; - private static final Pattern SPECIFICATION_VERSION_PATTERN = - Pattern.compile("([0-9]+\\.[0-9]+)(.*?)"); + private static final Pattern SPECIFICATION_VERSION_PATTERN = Pattern.compile("([0-9]+\\.[0-9]+)(.*?)"); static { List artifactExpressionPrefixes = new ArrayList<>();