fix: Normalize query params in dataset create_items_public_url

Author: vdusek

src/apify_client/_resource_clients/dataset.py

@@ -607,7 +607,8 @@ def create_items_public_url(
             request_params['signature'] = signature
 
         items_public_url = urlparse(self._build_url('items', public=True))
-        filtered_params = {k: v for k, v in request_params.items() if v is not None}
+        # Normalize params (bool→true/false, list→comma-joined) the same way the HTTP request path does.
+        filtered_params = self._http_client._parse_params(request_params)  # noqa: SLF001
         if filtered_params:
             items_public_url = items_public_url._replace(query=urlencode(filtered_params))
 
@@ -1173,7 +1174,8 @@ async def create_items_public_url(
             request_params['signature'] = signature
 
         items_public_url = urlparse(self._build_url('items', public=True))
-        filtered_params = {k: v for k, v in request_params.items() if v is not None}
+        # Normalize params (bool→true/false, list→comma-joined) the same way the HTTP request path does.
+        filtered_params = self._http_client._parse_params(request_params)  # noqa: SLF001
         if filtered_params:
             items_public_url = items_public_url._replace(query=urlencode(filtered_params))
 

tests/unit/test_url_generation.py

@@ -3,6 +3,7 @@
 import json
 from unittest import mock
 from unittest.mock import Mock
+from urllib.parse import parse_qs, urlparse
 
 import pytest
 
@@ -128,6 +129,40 @@ async def test_dataset_public_url_async(api_url: str, api_public_url: str | None
         )
 
 
+def test_dataset_public_url_normalizes_params_sync() -> None:
+    """Bool and list query params must be API-normalized (bool→true/false, list→comma-joined), not Python reprs."""
+    client = ApifyClient(token='dummy-token', api_url='https://api.apify.com')
+    dataset = client.dataset('someID')
+
+    mock_response = Mock()
+    mock_response.json.return_value = json.loads(MOCKED_DATASET_RESPONSE)
+
+    with mock.patch.object(client._http_client, 'call', return_value=mock_response):
+        public_url = dataset.create_items_public_url(clean=True, desc=False, fields=['title', 'url'])
+
+    query = parse_qs(urlparse(public_url).query)
+    assert query['clean'] == ['true']
+    assert query['desc'] == ['false']
+    assert query['fields'] == ['title,url']
+
+
+async def test_dataset_public_url_normalizes_params_async() -> None:
+    """Bool and list query params must be API-normalized (bool→true/false, list→comma-joined), not Python reprs."""
+    client = ApifyClientAsync(token='dummy-token', api_url='https://api.apify.com')
+    dataset = client.dataset('someID')
+
+    mock_response = Mock()
+    mock_response.json.return_value = json.loads(MOCKED_DATASET_RESPONSE)
+
+    with mock.patch.object(client._http_client, 'call', return_value=mock_response):
+        public_url = await dataset.create_items_public_url(clean=True, desc=False, fields=['title', 'url'])
+
+    query = parse_qs(urlparse(public_url).query)
+    assert query['clean'] == ['true']
+    assert query['desc'] == ['false']
+    assert query['fields'] == ['title,url']
+
+
 # ============================================================================
 # Key-value store URL generation tests
 # ============================================================================