feat: add support for saving and applying sdk customizations#251
Merged
Conversation
…b.com/apimatic/apimatic-cli into ayeshas09/update-sdk-generate-command
…tic/apimatic-cli into ayeshas09-feat-custom-code
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 40 out of 42 changed files in this pull request and generated 17 comments.
Comments suppressed due to low confidence (2)
src/hooks/not-found.ts:56
argvis now alwaysopts.argv ?? [], which drops the previous fallback that derived arguments fromopts.idwhenopts.argvwas empty/undefined. This can cause suggested commands to be re-run without the user-provided args (behavior regression vs the original oclif plugin). Consider restoring the previous fallback logic so arguments are preserved when accepting a suggestion.
if (response) {
const confirmedSuggestion = suggestion!;
let argv = opts.argv ?? [];
if (confirmedSuggestion.startsWith("help:")) {
argv = confirmedSuggestion.split(":").slice(1);
suggestion = "help";
}
return this.config.runCommand(confirmedSuggestion, argv);
src/prompts/portal/generate.ts:8
- There are unused imports here (
ServiceErrorCode,noteWrapped). This will fail linting/TypeScript noUnusedLocals settings if enabled. Remove unused imports or use them as intended.
import {ServiceError } from "../../infrastructure/service-error.js";
import { withSpinner } from "../prompt.js";
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…tic/apimatic-cli into ayeshas09-feat-custom-code
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tic/apimatic-cli into ayeshas09-feat-custom-code
…te action - Add .ai/skills/event.md for domain event conventions - Strengthen context.md rule: public methods must use domain-specific private fields - Extract named variables in generate.ts for clarity - Add private zipPath getter to SdkContext; clean up style Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tic/apimatic-cli into ayeshas09-feat-custom-code
Add rules for method naming redundancy (don't embed the context's own domain subject in method names) and callback path leakage (don't pass internal paths through callback parameters). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Shield-Jaguar
approved these changes
Apr 9, 2026
Shield-Jaguar
left a comment
Contributor
There was a problem hiding this comment.
There are still some fundamental code issues that needs to be fixed. They will be fixed later in another pull request.
sohail2721
approved these changes
Apr 9, 2026
asadali214
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


No description provided.