Skip to content

feat: add support for saving and applying sdk customizations#251

Merged
asadali214 merged 128 commits into
devfrom
ayeshas09-feat-custom-code
Apr 9, 2026
Merged

feat: add support for saving and applying sdk customizations#251
asadali214 merged 128 commits into
devfrom
ayeshas09-feat-custom-code

Conversation

@Ayeshas09

Copy link
Copy Markdown
Contributor

No description provided.

Ayeshas09 and others added 30 commits November 11, 2025 15:44

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 40 out of 42 changed files in this pull request and generated 17 comments.

Comments suppressed due to low confidence (2)

src/hooks/not-found.ts:56

  • argv is now always opts.argv ?? [], which drops the previous fallback that derived arguments from opts.id when opts.argv was empty/undefined. This can cause suggested commands to be re-run without the user-provided args (behavior regression vs the original oclif plugin). Consider restoring the previous fallback logic so arguments are preserved when accepting a suggestion.
  if (response) {
    const confirmedSuggestion = suggestion!;
    let argv = opts.argv ?? [];

    if (confirmedSuggestion.startsWith("help:")) {
      argv = confirmedSuggestion.split(":").slice(1);
      suggestion = "help";
    }

    return this.config.runCommand(confirmedSuggestion, argv);

src/prompts/portal/generate.ts:8

  • There are unused imports here (ServiceErrorCode, noteWrapped). This will fail linting/TypeScript noUnusedLocals settings if enabled. Remove unused imports or use them as intended.
import {ServiceError } from "../../infrastructure/service-error.js";
import { withSpinner } from "../prompt.js";


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/infrastructure/git-service.ts
Comment thread src/infrastructure/git-service.ts Outdated
Comment thread src/infrastructure/git-service.ts
Comment thread src/actions/sdk/generate.ts Outdated
Comment thread src/actions/sdk/generate.ts
Comment thread src/types/temp-context.ts
Comment thread src/types/sdk-context.ts Outdated
Comment thread src/types/build-context.ts
Comment thread src/actions/sdk/generate.ts
Comment thread src/actions/sdk/save-changes.ts
@asadali214 asadali214 self-requested a review April 8, 2026 11:28
Ayeshas09 and others added 18 commits April 8, 2026 16:35
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…te action

- Add .ai/skills/event.md for domain event conventions
- Strengthen context.md rule: public methods must use domain-specific private fields
- Extract named variables in generate.ts for clarity
- Add private zipPath getter to SdkContext; clean up style

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Add rules for method naming redundancy (don't embed the context's own
domain subject in method names) and callback path leakage (don't pass
internal paths through callback parameters).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sonarqubecloud

sonarqubecloud Bot commented Apr 9, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@Shield-Jaguar Shield-Jaguar left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some fundamental code issues that needs to be fixed. They will be fixed later in another pull request.

@asadali214 asadali214 requested a review from sohail2721 April 9, 2026 10:16
@asadali214 asadali214 merged commit 113ac70 into dev Apr 9, 2026
1 of 6 checks passed
@asadali214 asadali214 deleted the ayeshas09-feat-custom-code branch April 9, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants