Skip to content

feat: update SKILL.md to add skills and guidelines#7

Merged
mohammadali2549 merged 19 commits into
devfrom
sohail/update-skills
Mar 26, 2026
Merged

feat: update SKILL.md to add skills and guidelines#7
mohammadali2549 merged 19 commits into
devfrom
sohail/update-skills

Conversation

@sohail2721

@sohail2721 sohail2721 commented Mar 24, 2026

Copy link
Copy Markdown
Collaborator

closes #8

Comment thread skills/integrate-context-matic/SKILL.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the integrate-context-matic skill documentation to add an initial setup step (ensuring guidelines/skills exist) and to revise the workflow/checklist around tool usage and milestone recording.

Changes:

  • Adds a new Step 1 to check for existing guidelines/skills and conditionally call add_guidelines and add_skills.
  • Renumbers and revises workflow steps, emphasizing ask usage and milestone-based update_activity calls.
  • Updates the milestone table and checklist to reflect the revised process.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/integrate-context-matic/SKILL.md
Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md
Comment thread skills/integrate-context-matic/SKILL.md
Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

Comments suppressed due to low confidence (1)

skills/integrate-context-matic/SKILL.md:74

  • The milestone list here includes values (first_call_attempted, first_call_succeeded, tests_passing) that do not match the enum described in Issue #8 (sdk_setup, auth_configured, first_call_made, error_encountered, error_resolved). If the tool only accepts the enum from the issue, these entries will lead to invalid update_activity calls; please align this table (and any referenced milestones) to the actual tool schema.
### 5. Record Milestones

Call **update_activity** (with the appropriate `milestone`) whenever one of these is observed or confirmed:

| Milestone | When to pass it |
|---|---|
| `sdk_setup` | SDK packages installed and environment confirmed set up |
| `auth_configured` | API keys or auth configured, ready to make first call |
| `first_call_attempted` | First API call code written and executed |
| `first_call_succeeded` | Successful response from first API call received |
| `error_encountered` | Developer reports a bug, error response, or failing call |
| `error_resolved` | Fix applied and API call confirmed working |
| `tests_passing` | Integration tests written and confirmed passing |

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread README.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md
Comment thread skills/integrate-context-matic/SKILL.md Outdated
mohammadali2549 and others added 2 commits March 25, 2026 12:07
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot AI commented Mar 25, 2026

Copy link
Copy Markdown
Contributor

@mohammadali2549 I've opened a new pull request, #11, to work on those changes. Once the pull request is ready, I'll request review from you.

mohammadali2549 and others added 3 commits March 25, 2026 12:13
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@mohammadali2549 mohammadali2549 requested a review from Copilot March 25, 2026 09:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment on lines +22 to +25
Before anything else, check whether guidelines and skills have already been added for this project by looking for their presence in the workspace. Check for existing skill and guideline files, e.g., `{language}-conventions`, `{language}-security-guidelines.md`, `{language}-test-guidelines.md`, `update-activity-workflow.md`, or prior output from `add_guidelines` and `add_skills`.

- **If they do not exist for the project's language:** Call **add_guidelines** and **add_skills** to create them. This sets up the necessary skills and guidelines for the MCP server to work correctly.
- **If they already exist for the project's language:** Skip this step entirely and proceed to step 2.

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Step 1 asks to check for guideline/skill files “for the project's language”, but the workflow doesn't establish/detect the project's primary language until step 2. To make this executable, either add an explicit language-detection substep before this check, or reword step 1 to be language-agnostic.

Suggested change
Before anything else, check whether guidelines and skills have already been added for this project by looking for their presence in the workspace. Check for existing skill and guideline files, e.g., `{language}-conventions`, `{language}-security-guidelines.md`, `{language}-test-guidelines.md`, `update-activity-workflow.md`, or prior output from `add_guidelines` and `add_skills`.
- **If they do not exist for the project's language:** Call **add_guidelines** and **add_skills** to create them. This sets up the necessary skills and guidelines for the MCP server to work correctly.
- **If they already exist for the project's language:** Skip this step entirely and proceed to step 2.
Before anything else, check whether guidelines and skills have already been added for this project by looking for their presence in the workspace. Check for existing skill and guideline files, e.g., `*-conventions.md`, `*-security-guidelines.md`, `*-test-guidelines.md`, `update-activity-workflow.md`, or prior output from `add_guidelines` and `add_skills`.
- **If relevant guidelines and skills do not exist for this project:** Call **add_guidelines** and **add_skills** to create them. This sets up the necessary skills and guidelines for the MCP server to work correctly.
- **If relevant guidelines and skills already exist for this project:** Skip this step entirely and proceed to step 2.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot add an explicit language-detection substep before this check

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit 959d02b. Step 1 is now split into two substeps:

  • 1a. Detect the Project's Primary Language — a lookup table maps common workspace file patterns (e.g. *.csprojcsharp, go.modgo) to the language value, and instructs the agent to use the detected language in all subsequent steps.
  • 1b. Check for Existing Guidelines and Skills — the existing check, now using the language identified in 1a.

Step 2 (fetch_api) is updated to reference "the language detected in step 1a" instead of repeating the detection logic.

Comment thread skills/integrate-context-matic/SKILL.md
Comment thread skills/integrate-context-matic/SKILL.md
Comment on lines +63 to 66
### 5. Record Milestones

Call **update_activity** (with the appropriate `milestone`) whenever one of these is observed or confirmed:

Copilot AI Mar 25, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section references passing an appropriate milestone, but the milestone values defined below include first_call_attempted / first_call_succeeded / tests_passing, which don't match the update_activity milestone enum described in Issue #8 (e.g., first_call_made). If the enum values are wrong, tool calls will fail—please align the milestone list to the actual tool schema.

Copilot uses AI. Check for mistakes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@copilot

Only the following milestones exist: "sdk_setup", "auth_configured", "first_call_made", "error_encountered", "error_resolved"

make necassary changes for them

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in commit c31f8cf. The milestone table now only contains the valid values: sdk_setup, auth_configured, first_call_made, error_encountered, error_resolved. Removed first_call_attempted, first_call_succeeded, and tests_passing, and corrected first_call_attemptedfirst_call_made.

Comment thread skills/integrate-context-matic/SKILL.md Outdated
Comment thread skills/integrate-context-matic/SKILL.md Outdated
mohammadali2549 and others added 2 commits March 25, 2026 15:12
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
… check in Step 1

Co-authored-by: mohammadali2549 <67632698+mohammadali2549@users.noreply.github.com>
Agent-Logs-Url: https://github.com/apimatic/context-matic/sessions/8b2d6cd7-4c84-4544-bc26-466a9ad5c9f9
@mohammadali2549 mohammadali2549 merged commit 958d700 into dev Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: integrate-context-matic skill calls update_activity with invalid 'phase' parameter

4 participants