From review of PR #81.
Two issues in .github/workflows/dotnet.yml:
1. git add -A in the lint job
The lint job auto-commits formatting fixes, but uses git add -A which stages everything — including any files the build/format process might create accidentally. Should use specific globs like git add '*.cs'.
2. lint and build run in parallel
Since they're independent jobs, build may test stale code if lint pushes a formatting commit while build is already running. The build job should depend on lint:
This ensures build always tests the final state of the code.
From review of PR #81.
Two issues in
.github/workflows/dotnet.yml:1.
git add -Ain the lint jobThe lint job auto-commits formatting fixes, but uses
git add -Awhich stages everything — including any files the build/format process might create accidentally. Should use specific globs likegit add '*.cs'.2.
lintandbuildrun in parallelSince they're independent jobs,
buildmay test stale code iflintpushes a formatting commit whilebuildis already running. Thebuildjob should depend onlint:This ensures build always tests the final state of the code.