PF2e integrations seems broken

[gnlatgh]

I tried my darnest to get it up and running but nothing seems to work.
running foundry version 9 - build 251
pathfinder 2nd edition - 3.5.2.10605
using let's encrypt SSL and DNS name that point to my server. Have no issues presenting SSL or port 30000 externally otherwise.

First the API doesn't seem to return anything, just the error:
Cannot GET /actorAPI/strength-of-thousands-actors.jsonQNHPucJI0sUS90bt

However by adding a questionmark I actually get a response, except I get a list of ALL actors. Not the one I specified.
https://(myurl):30000/actorAPI/strength-of-thousands-actors.json?QNHPucJI0sUS90bt

Now to the next step, presenting the sheet on
https://ardittristan.github.io/VTTExternalActorSites/pf2e/?https://(myurl):30000/actorAPI/strength-of-thousands-actors.json?QNHPucJI0sUS90bt

Just give the error "Actor retrieving Not Data Found" (with or without questionmark)

I also tried to handcraft the json file in my ActorAPI folder to only show the one actor I want to present but error is the same.

[ardittristan]

is the domain public or is it a localhost?
localhost doesn't work, if it's public I'll take a look at it somewhere this week!

[gnlatgh]

It's public domain, also contacted you on discord if you want to see the API in person.

[Teifun2]

I seem to have the same issue!

I checked and the actor.json is properly returened. So for some weird reason the page crashes with error "URL not found"

Did you figure out why?

[Teifun2]

Further investigation shows that the method showSheet is broken

TypeError: Cannot read properties of undefined (reading 'label')

[gnlatgh]

I seem to have the same issue!

I checked and the actor.json is properly returened. So for some weird reason the page crashes with error "URL not found"

Did you figure out why?

ardittristan confirmed it was broken and made some initial fixes but nothing since mar 21. ExternalActorSites need to be redesigned to be compatible with latest design from pf2 foundry team I guess.

If you've implemented it correctly you should be able to reach VTTExternalActorSites and not get "URL not found" but with broken css.

[ardittristan]

I've been busy lately, sorry! Though gnlatgh is correct, could you maybe supply your actors.json so i can check what's going wrong? (And preferably actor is as well)

[Teifun2]

@ardittristan Any way i can send you a link privately?

I checked it out a little further. It was an issue with the following code segment.
https://github.com/ardittristan/VTTExternalActorSite/blob/master/src/populatesheet.js#L82

This iterates over all skills ("acr","ath","cra","dec" etc.) but then searches for the label of an abilitiy with the shortname of the skill 😕
actorData.data.abilities[skl.ability]

This can obviously not work as in data.abilities we only have "str" "dex" "con" "int" etc. and these dont match.
I am very confused what exactly this should do!

[Teifun2]

I uncommented the line in a local copy to check if it is the only thing that is blocking it, but sadly there is more!
https://github.com/ardittristan/VTTExternalActorSite/blob/master/src/populatesheet.js#L254 + https://github.com/ardittristan/VTTExternalActorSite/blob/master/src/populatesheet.js#L291

Crash as they expect spells to be under actorData.data.spells.

This seems to be no longer the case. In my current export json i can find all spells under actorData.items.

I added my full world dump json here. (it is from the beginner box for PF2e. You should be able to add it to your world data and just call it. I usually used Actor: "WNX5OQKPh4uaV7mW" (Ezren)
pathfinder-2e-beginer-box-actors.txt

YourHOST/actorAPI/pathfinder-2e-beginer-box-actors.jsonWNX5OQKPh4uaV7mW