Skip to content

Conversation

@igorpecovnik
Copy link
Member

@igorpecovnik igorpecovnik commented Nov 24, 2025

Description

Enable Thunderbolt support only in amd64 arch.

How Has This Been Tested?

  • Tested on TB4 x86 laptop

Checklist:

  • My code follows the style guidelines of this project

Summary by CodeRabbit

  • Chores
    • Removed bolt package from GNOME desktop configuration
    • Added bolt and thunderbolt-tools packages to amd64 CLI configurations for both sid and trixie environments

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 24, 2025

Walkthrough

Reorganizes thunderbolt-related packages across configurations: removes "bolt" from GNOME config_base packages, and adds both "bolt" and "thunderbolt-tools" to amd64 CLI configurations for sid and trixie distributions.

Changes

Cohort / File(s) Summary
GNOME Configuration
config/desktop/common/environments/gnome/config_base/packages
Removed "bolt" package entry
amd64 CLI Configurations
config/optional/architectures/amd64/_config/cli/sid/main/packages, config/optional/architectures/amd64/_config/cli/trixie/main/packages
Added "bolt" and "thunderbolt-tools" package entries to both sid and trixie CLI configs

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

  • Simple package list modifications with no logic changes
  • Straightforward addition and removal of entries in configuration files

Suggested labels

size/small

Suggested reviewers

  • igorpecovnik
  • EvilOlaf

Poem

🐰 A bolt hops from the GNOME nest so bright,
To sid and trixie in the amd64 light,
With thunderbolt-tools as a trusty friend,
Package paths take a turn and bend! ⚡

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main changes: removing bolt from GNOME desktop packages while adding thunderbolt support to amd64 architecture CLI configs.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch thunderbolt

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between e8551cb and 874cf88.

📒 Files selected for processing (3)
  • config/desktop/common/environments/gnome/config_base/packages (0 hunks)
  • config/optional/architectures/amd64/_config/cli/sid/main/packages (1 hunks)
  • config/optional/architectures/amd64/_config/cli/trixie/main/packages (1 hunks)
💤 Files with no reviewable changes (1)
  • config/desktop/common/environments/gnome/config_base/packages
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-07-23T10:01:36.094Z
Learnt from: amazingfate
Repo: armbian/build PR: 8419
File: lib/functions/configuration/main-config.sh:373-376
Timestamp: 2025-07-23T10:01:36.094Z
Learning: Debian sid (unstable) does not use separate security repositories like stable releases. Security fixes in sid are incorporated directly into regular package updates, so DEBIAN_SECURTY configuration is not needed for sid builds.

Applied to files:

  • config/optional/architectures/amd64/_config/cli/sid/main/packages
🔇 Additional comments (2)
config/optional/architectures/amd64/_config/cli/trixie/main/packages (1)

2-3: Consistent Thunderbolt package additions across distributions.

The addition of bolt and thunderbolt-tools mirrors the changes in the sid configuration, ensuring consistent Thunderbolt support across both Debian stable (trixie) and unstable (sid) for amd64 CLI builds. Both packages are available in Debian trixie (bolt 0.9.8-1 and thunderbolt-tools 0.9.3-7).

config/optional/architectures/amd64/_config/cli/sid/main/packages (1)

2-3: Thunderbolt packages verified correctly for amd64 CLI.

Both bolt (0.9.10-1) and thunderbolt-tools (0.9.3-8) are available in Debian sid. The removal of bolt from GNOME desktop packages was confirmed via git diff (config/desktop/common/environments/gnome/config_base/packages), aligning with the PR's intent to scope Thunderbolt support specifically to amd64 minimal builds rather than desktop environments.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines labels Nov 24, 2025
@igorpecovnik igorpecovnik added 02 Milestone: First quarter release and removed 11 Milestone: Fourth quarter release size/small PR with less then 50 lines labels Nov 24, 2025
@github-actions github-actions bot added Desktop Graphical user interface Needs review Seeking for review labels Nov 24, 2025
@igorpecovnik igorpecovnik merged commit b1a85e0 into main Nov 24, 2025
12 checks passed
@igorpecovnik igorpecovnik deleted the thunderbolt branch November 24, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

02 Milestone: First quarter release Desktop Graphical user interface Needs review Seeking for review

Development

Successfully merging this pull request may close these issues.

2 participants