There are a few moments in the code base with unhandled exceptions that could make it harder to the users to understand the errors.
Examples:
- experimental_syntax_encoding.py, line 52 -> transform source could be None. We could either raise a better error here or replace None with
lambda s: s.
- Same file, line 15 -> search_function can return None instead of an encoding. Even though it's incredibly unlikely, mypy/pylance won't like it and in the future we might encounter cases where utf-8 is not available. In that case, adding a single check in the beginning can help the users in that rare case. Additionally, less red text is good :)
I am not touching on examples because they obviously need a bit less error handling.
There are a few moments in the code base with unhandled exceptions that could make it harder to the users to understand the errors.
Examples:
lambda s: s.I am not touching on examples because they obviously need a bit less error handling.