feat(pds): implement com.atproto.sync.getLatestCommit#168
Merged
Conversation
The endpoint was unimplemented, so requests fell through to the XRPC proxy
and returned 501. Relays call getLatestCommit during crawl bootstrap, so a
freshly created repo could never be indexed by a fresh requestCrawl. It now
returns the repo head commit { cid, rev } from rpcGetRepoStatus.
Closes ascorbic#167
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This was referenced May 23, 2026
commit: |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #167
What this is
A spec-conformance fix:
com.atproto.sync.getLatestCommithas no route, so requests fall through to the catch-all XRPC proxy and return501 MethodNotImplemented. It's a standard sync endpoint and should return200.Change
getLatestCommithandler inpackages/pds/src/xrpc/sync.ts, mirroringgetRepoStatusfordidvalidation /RepoNotFound/ deactivated handling. It returns{ cid, rev }(the lexicon output) sourced fromAccountDurableObject.rpcGetRepoStatus()— the same data already used bygetRepoStatus/listRepos.packages/pds/src/index.tsbefore the catch-all proxy.did→ 400, unknowndid→ 404).minor).Verification
pnpm --filter @getcirrus/pds build✅pnpm --filter @getcirrus/pds test:unit✅ (282 passed)pnpm knip✅🤖 Generated with Claude Code