fix(chat/migrations): fix migrations

- remove buggy soft deletes
  --> we do not yet differentiate between what has been
  deleted and what is still used but rolling back now is as easy
  as just installing an older version
  --> we can differentiate later (maybe even doing a hard delete later
  instead of a soft delete)
- add and switch to debug logging statements for all control structures

Author: adi-wan-askui

src/askui/chat/migrations/versions/057f82313448_import_json_assistants.py

@@ -33,6 +33,7 @@ def _insert_assistants_batch(
 ) -> None:
     """Insert a batch of assistants into the database, ignoring conflicts."""
     if not assistants_batch:
+        logger.debug("No assistants to insert, skipping batch")
         return
 
     connection.execute(
@@ -50,6 +51,10 @@ def upgrade() -> None:
 
     # Skip if directory doesn't exist (e.g., first-time setup)
     if not assistants_dir.exists():
+        logger.debug(
+            "Assistants directory does not exist, skipping import of assistants",
+            extra={"assistants_dir": str(assistants_dir)},
+        )
         return
 
     # Get the table from the current database schema
@@ -94,6 +99,9 @@ def downgrade() -> None:
     result = connection.execute(assistants_table.select())
     rows = result.fetchall()
     if not rows:
+        logger.debug(
+            "No assistants found in the database, skipping export of rows to json",
+        )
         return
 
     for row in rows:
@@ -103,6 +111,10 @@ def downgrade() -> None:
             )
             json_path = assistants_dir / f"{assistant.id}.json"
             if json_path.exists():
+                logger.debug(
+                    "Json file for assistant already exists, skipping export of row to json",
+                    extra={"assistant_id": assistant.id, "json_path": str(json_path)},
+                )
                 continue
             with json_path.open("w", encoding="utf-8") as f:
                 f.write(assistant.model_dump_json())

src/askui/chat/migrations/versions/1a2b3c4d5e6f_create_threads_table.py

@@ -1,7 +1,7 @@
 """create_threads_table
 
 Revision ID: 1a2b3c4d5e6f
-Revises: a0f1a2b3c4d5
+Revises: 9e0f1a2b3c4d
 Create Date: 2025-01-27 12:00:00.000000
 
 """
@@ -13,7 +13,7 @@
 
 # revision identifiers, used by Alembic.
 revision: str = "1a2b3c4d5e6f"
-down_revision: Union[str, None] = "a0f1a2b3c4d5"
+down_revision: Union[str, None] = "9e0f1a2b3c4d"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 

src/askui/chat/migrations/versions/2b3c4d5e6f7a_create_messages_table.py

@@ -1,7 +1,7 @@
 """create_messages_table
 
 Revision ID: 2b3c4d5e6f7a
-Revises: 1a2b3c4d5e6f
+Revises: 3c4d5e6f7a8b
 Create Date: 2025-01-27 12:01:00.000000
 
 """
@@ -13,7 +13,7 @@
 
 # revision identifiers, used by Alembic.
 revision: str = "2b3c4d5e6f7a"
-down_revision: Union[str, None] = "1a2b3c4d5e6f"
+down_revision: Union[str, None] = "3c4d5e6f7a8b"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 

src/askui/chat/migrations/versions/37007a499ca7_soft_delete_assistants_dir.py

@@ -1,7 +1,7 @@
 """create_runs_table
 
 Revision ID: 3c4d5e6f7a8b
-Revises: 2b3c4d5e6f7a
+Revises: 1a2b3c4d5e6f
 Create Date: 2025-01-27 12:02:00.000000
 
 """
@@ -13,7 +13,7 @@
 
 # revision identifiers, used by Alembic.
 revision: str = "3c4d5e6f7a8b"
-down_revision: Union[str, None] = "2b3c4d5e6f7a"
+down_revision: Union[str, None] = "1a2b3c4d5e6f"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 

src/askui/chat/migrations/versions/3c4d5e6f7a8b_create_runs_table.py

@@ -33,6 +33,7 @@ def _insert_threads_batch(
 ) -> None:
     """Insert a batch of threads into the database, ignoring conflicts."""
     if not threads_batch:
+        logger.debug("No threads to insert, skipping batch")
         return
 
     connection.execute(
@@ -50,6 +51,10 @@ def upgrade() -> None:  # noqa: C901
 
     # Skip if workspaces directory doesn't exist (e.g., first-time setup)
     if not workspaces_dir.exists():
+        logger.debug(
+            "Workspaces directory does not exist, skipping import of threads",
+            extra={"workspaces_dir": str(workspaces_dir)},
+        )
         return
 
     # Get the table from the current database schema
@@ -62,12 +67,20 @@ def upgrade() -> None:  # noqa: C901
     # Iterate through all workspace directories
     for workspace_dir in workspaces_dir.iterdir():
         if not workspace_dir.is_dir():
+            logger.debug(
+                "Skipping non-directory in workspaces",
+                extra={"path": str(workspace_dir)},
+            )
             continue
 
         workspace_id = workspace_dir.name
         threads_dir = workspace_dir / "threads"
 
         if not threads_dir.exists():
+            logger.debug(
+                "Threads directory does not exist, skipping workspace",
+                extra={"workspace_id": workspace_id, "threads_dir": str(threads_dir)},
+            )
             continue
 
         # Get all JSON files in the threads directory
@@ -102,6 +115,9 @@ def downgrade() -> None:
     result = connection.execute(threads_table.select())
     rows = result.fetchall()
     if not rows:
+        logger.debug(
+            "No threads found in the database, skipping export of rows to json",
+        )
         return
 
     for row in rows:
@@ -111,6 +127,10 @@ def downgrade() -> None:
             threads_dir.mkdir(parents=True, exist_ok=True)
             json_path = threads_dir / f"{thread_model.id}.json"
             if json_path.exists():
+                logger.debug(
+                    "Json file for thread already exists, skipping export of row to json",
+                    extra={"thread_id": thread_model.id, "json_path": str(json_path)},
+                )
                 continue
             with json_path.open("w", encoding="utf-8") as f:
                 f.write(thread_model.model_dump_json())

src/askui/chat/migrations/versions/4d5e6f7a8b9c_import_json_threads.py

@@ -1,7 +1,7 @@
 """create_mcp_configs_table
 
 Revision ID: 5a1b2c3d4e5f
-Revises: 37007a499ca7
+Revises: c35e88ea9595
 Create Date: 2025-01-27 10:00:00.000000
 
 """
@@ -13,7 +13,7 @@
 
 # revision identifiers, used by Alembic.
 revision: str = "5a1b2c3d4e5f"
-down_revision: Union[str, None] = "37007a499ca7"
+down_revision: Union[str, None] = "c35e88ea9595"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 

src/askui/chat/migrations/versions/5a1b2c3d4e5f_create_mcp_configs_table.py

@@ -1,7 +1,7 @@
 """import_json_messages
 
 Revision ID: 5e6f7a8b9c0d
-Revises: 4d5e6f7a8b9c
+Revises: 6f7a8b9c0d1e
 Create Date: 2025-01-27 12:04:00.000000
 
 """
@@ -18,7 +18,7 @@
 
 # revision identifiers, used by Alembic.
 revision: str = "5e6f7a8b9c0d"
-down_revision: Union[str, None] = "4d5e6f7a8b9c"
+down_revision: Union[str, None] = "6f7a8b9c0d1e"
 branch_labels: Union[str, Sequence[str], None] = None
 depends_on: Union[str, Sequence[str], None] = None
 
@@ -33,6 +33,7 @@ def _insert_messages_batch(
 ) -> None:
     """Insert a batch of messages into the database, handling foreign key violations."""
     if not messages_batch:
+        logger.debug("No messages to insert, skipping batch")
         return
 
     # Validate and fix foreign key references
@@ -56,6 +57,7 @@ def _validate_and_fix_foreign_keys(  # noqa: C901
     - If run_id is invalid: set to None
     """
     if not messages_batch:
+        logger.debug("Empty message batch, nothing to validate")
         return []
 
     # Extract all foreign key values
@@ -180,6 +182,10 @@ def upgrade() -> None:  # noqa: C901
     """Import existing messages from JSON files in workspace directories."""
     # Skip if workspaces directory doesn't exist (e.g., first-time setup)
     if not workspaces_dir.exists():
+        logger.debug(
+            "Workspaces directory does not exist, skipping import of messages",
+            extra={"workspaces_dir": str(workspaces_dir)},
+        )
         return
 
     # Get the table from the current database schema
@@ -192,17 +198,29 @@ def upgrade() -> None:  # noqa: C901
     # Iterate through all workspace directories
     for workspace_dir in workspaces_dir.iterdir():
         if not workspace_dir.is_dir():
+            logger.debug(
+                "Skipping non-directory in workspaces",
+                extra={"path": str(workspace_dir)},
+            )
             continue
 
         workspace_id = workspace_dir.name
         messages_dir = workspace_dir / "messages"
 
         if not messages_dir.exists():
+            logger.debug(
+                "Messages directory does not exist, skipping workspace",
+                extra={"workspace_id": workspace_id, "messages_dir": str(messages_dir)},
+            )
             continue
 
         # Iterate through thread directories
         for thread_dir in messages_dir.iterdir():
             if not thread_dir.is_dir():
+                logger.debug(
+                    "Skipping non-directory in messages",
+                    extra={"path": str(thread_dir)},
+                )
                 continue
 
             # Get all JSON files in the thread directory
@@ -241,6 +259,9 @@ def downgrade() -> None:
     result = connection.execute(messages_table.select())
     rows = result.fetchall()
     if not rows:
+        logger.debug(
+            "No messages found in the database, skipping export of rows to json",
+        )
         return
 
     for row in rows:
@@ -257,6 +278,10 @@ def downgrade() -> None:
             messages_dir.mkdir(parents=True, exist_ok=True)
             json_path = messages_dir / f"{message_model.id}.json"
             if json_path.exists():
+                logger.debug(
+                    "Json file for message already exists, skipping export of row to json",
+                    extra={"message_id": message_model.id, "json_path": str(json_path)},
+                )
                 continue
             with json_path.open("w", encoding="utf-8") as f:
                 f.write(message_model.model_dump_json())

src/askui/chat/migrations/versions/5e6f7a8b9c0d_import_json_messages.py

@@ -35,6 +35,7 @@ def _insert_mcp_configs_batch(
 ) -> None:
     """Insert a batch of MCP configs into the database, ignoring conflicts."""
     if not mcp_configs_batch:
+        logger.debug("No MCP configs to insert, skipping batch")
         return
 
     connection.execute(
@@ -52,6 +53,10 @@ def upgrade() -> None:
 
     # Skip if directory doesn't exist (e.g., first-time setup)
     if not mcp_configs_dir.exists():
+        logger.debug(
+            "MCP configs directory does not exist, skipping import of MCP configs",
+            extra={"mcp_configs_dir": str(mcp_configs_dir)},
+        )
         return
 
     # Get the table from the current database schema
@@ -97,6 +102,9 @@ def downgrade() -> None:
     result = connection.execute(mcp_configs_table.select())
     rows = result.fetchall()
     if not rows:
+        logger.debug(
+            "No MCP configs found in the database, skipping export of rows to json",
+        )
         return
 
     for row in rows:
@@ -106,6 +114,10 @@ def downgrade() -> None:
             )
             json_path = mcp_configs_dir / f"{mcp_config.id}.json"
             if json_path.exists():
+                logger.debug(
+                    "Json file for mcp config already exists, skipping export of row to json",
+                    extra={"mcp_config_id": mcp_config.id, "json_path": str(json_path)},
+                )
                 continue
             with json_path.open("w", encoding="utf-8") as f:
                 f.write(mcp_config.model_dump_json())