ref: Rename external-packages to on-the-fly, unskip #137 tests

- Rename `examples/external-packages/` → `examples/on-the-fly/`
- Unskip create/createResource tests now that the duplicate meta key fix landed
- Remove `continue-on-error` from CI jobs
- Update examples/README.md with on-the-fly section

Author: ryukzak

.github/workflows/sdk-tests.yml

@@ -246,11 +246,9 @@ jobs:
         run: bun install --frozen-lockfile
 
       - name: Run tests
-        # TODO(#137): remove continue-on-error once duplicate meta key bug is fixed
-        continue-on-error: true
         run: make test-local-package-folder-example
 
-  test-external-packages-example:
+  test-on-the-fly-example:
     runs-on: ubuntu-latest
 
     strategy:
@@ -269,9 +267,7 @@ jobs:
         run: bun install --frozen-lockfile
 
       - name: Run tests
-        # TODO(#137): remove continue-on-error once duplicate meta key bug is fixed (KBV typecheck fails with TS1117)
-        continue-on-error: true
-        run: make test-external-packages-example
+        run: make test-on-the-fly-example
 
   test-mustache-java-r4-example:
     runs-on: ubuntu-latest

Makefile

@@ -57,15 +57,15 @@ test-all-example-generation: test-other-example-generation
 	bun run examples/typescript-sql-on-fhir/generate.ts
 	bun run examples/typescript-us-core/generate.ts
 
-test-other-example-generation: test-external-packages-example
-
-test-external-packages-example:
-	bun run examples/external-packages/norge-r4/generate.ts
-	$(TYPECHECK) --project examples/external-packages/norge-r4/tsconfig.json
-	$(TEST) ./examples/external-packages/norge-r4/
-	bun run examples/external-packages/kbv-r4/generate.ts
-	$(TYPECHECK) --project examples/external-packages/kbv-r4/tsconfig.json
-	$(TEST) ./examples/external-packages/kbv-r4/
+test-other-example-generation: test-on-the-fly-example
+
+test-on-the-fly-example:
+	bun run examples/on-the-fly/norge-r4/generate.ts
+	$(TYPECHECK) --project examples/on-the-fly/norge-r4/tsconfig.json
+	$(TEST) ./examples/on-the-fly/norge-r4/
+	bun run examples/on-the-fly/kbv-r4/generate.ts
+	$(TYPECHECK) --project examples/on-the-fly/kbv-r4/tsconfig.json
+	$(TEST) ./examples/on-the-fly/kbv-r4/
 
 test-typescript-r4-example: typecheck format lint
 	bun run examples/typescript-r4/generate.ts

examples/README.md

@@ -58,6 +58,18 @@ This directory contains working examples demonstrating the capabilities of Atomi
   - Demonstrates dependency resolution with FHIR R4 core
   - Shows tree shaking for custom logical models
 
+### On-the-Fly Generation
+
+These examples pull packages from the FHIR registry and generate types on-the-fly (generated types are gitignored and regenerated on CI).
+
+- **[on-the-fly/norge-r4/](on-the-fly/norge-r4/)** - Norwegian FHIR profiles (Grunndata, no-basis, SFM)
+  - `generate.ts` - Fetches multiple Norwegian FHIR packages from Simplifier
+  - Demonstrates `preprocessPackage` for fixing package metadata and dependency injection
+
+- **[on-the-fly/kbv-r4/](on-the-fly/kbv-r4/)** - German KBV profiles (kbv.ita.for)
+  - `generate.ts` - Fetches KBV packages with `ignorePackageIndex: true` for corrupt package indices
+  - `profile-patient.test.ts` - Regression test for `meta` merge in profiles with required `meta` (#137)
+
 ## Running Examples
 
 Each example contains a `generate.ts` script that can be run with:

examples/local-package-folder/__snapshots__/profile-meta-required.test.ts.snap

@@ -0,0 +1,14 @@
+// Bun Snapshot v1, https://bun.sh/docs/test/snapshots
+
+exports[`demo: create a patient with required meta create sets meta.profile and preserves caller meta fields 1`] = `
+{
+  "meta": {
+    "lastUpdated": "2024-01-01T00:00:00Z",
+    "profile": [
+      "http://example.org/fhir/StructureDefinition/PatientMetaRequired",
+    ],
+    "versionId": "1",
+  },
+  "resourceType": "Patient",
+}
+`;

examples/local-package-folder/profile-meta-required.test.ts

@@ -1,9 +1,8 @@
 /**
  * PatientMetaRequired profile demo — exercises a profile where `meta` is required (min: 1).
  *
- * This is a regression scenario for issue #137: when `meta` is required, `createResource()`
- * must merge the caller's meta fields with the auto-set `meta.profile` array, not emit
- * two separate `meta:` keys.
+ * Regression test for #137: `createResource()` merges the caller's meta fields
+ * with the auto-set `meta.profile` array via spread.
  */
 
 import { describe, expect, test } from "bun:test";
@@ -13,9 +12,7 @@ import type { Patient } from "./fhir-types/hl7-fhir-r4-core/Patient";
 const canonicalUrl = "http://example.org/fhir/StructureDefinition/PatientMetaRequired";
 
 describe("demo: create a patient with required meta", () => {
-    // TODO(#137): create/createResource emit duplicate `meta:` keys — caller meta is overwritten.
-    // Un-skip once the codegen fix merges the two meta values.
-    test.skip("create sets meta.profile and preserves caller meta fields", () => {
+    test("create sets meta.profile and preserves caller meta fields", () => {
         const profile = PatientMetaRequiredProfile.create({
             meta: { versionId: "1", lastUpdated: "2024-01-01T00:00:00Z" },
         });
@@ -33,7 +30,7 @@ describe("demo: create a patient with required meta", () => {
         expect(resource).toMatchSnapshot();
     });
 
-    test.skip("createResource also merges meta correctly", () => {
+    test("createResource also merges meta correctly", () => {
         const resource = PatientMetaRequiredProfile.createResource({
             meta: { versionId: "2" },
         });

…ples/external-packages/kbv-r4/.gitignore examples/on-the-fly/kbv-r4/.gitignoreexamples/external-packages/kbv-r4/.gitignore renamed to examples/on-the-fly/kbv-r4/.gitignore examples/external-packages/kbv-r4/.gitignore renamed to examples/on-the-fly/kbv-r4/.gitignore

@@ -41,7 +41,7 @@ if (require.main === module) {
             openResourceTypeSet: false,
         })
         .typeSchema({})
-        .outputTo("./examples/external-packages/kbv-r4/fhir-types")
+        .outputTo("./examples/on-the-fly/kbv-r4/fhir-types")
         .cleanOutput(true);
 
     const report = await builder.generate();

…les/external-packages/kbv-r4/generate.ts examples/on-the-fly/kbv-r4/generate.tsexamples/external-packages/kbv-r4/generate.ts renamed to examples/on-the-fly/kbv-r4/generate.ts examples/external-packages/kbv-r4/generate.ts renamed to examples/on-the-fly/kbv-r4/generate.ts

@@ -1,9 +1,8 @@
 /**
  * KBV_PR_FOR_Patient profile — regression test for duplicate meta key (#137).
  *
- * KBV profiles require `meta` (min: 1). Until the codegen fix merges caller meta
- * with the auto-set meta.profile, `createResource` emits two `meta:` keys and
- * the caller-provided meta is silently overwritten.
+ * KBV profiles require `meta` (min: 1). The codegen now merges caller meta
+ * with the auto-set meta.profile via spread.
  */
 
 import { describe, expect, test } from "bun:test";
@@ -13,8 +12,7 @@ import { KBV_PR_FOR_PatientProfile } from "./fhir-types/kbv-ita-for/profiles/Pat
 const canonicalUrl = "https://fhir.kbv.de/StructureDefinition/KBV_PR_FOR_Patient";
 
 describe("demo: KBV Patient with required meta", () => {
-    // TODO(#137): createResource emits duplicate `meta:` keys — caller meta is overwritten.
-    test.skip("create preserves caller meta fields alongside meta.profile", () => {
+    test("create preserves caller meta fields alongside meta.profile", () => {
         const profile = KBV_PR_FOR_PatientProfile.create({
             name: [{ family: "Müller", given: ["Hans"] }],
             birthDate: "1990-01-15",
@@ -28,7 +26,7 @@ describe("demo: KBV Patient with required meta", () => {
         expect(resource.meta?.lastUpdated).toBe("2024-01-01T00:00:00Z");
     });
 
-    test.skip("createResource merges meta correctly", () => {
+    test("createResource merges meta correctly", () => {
         const resource = KBV_PR_FOR_PatientProfile.createResource({
             name: [{ family: "Schmidt" }],
             birthDate: "1985-06-20",