Fix a lot of biome suggestions.

Author: ryukzak

Makefile

@@ -2,7 +2,7 @@ AIDBOX_LICENSE_ID ?=
 
 TYPECHECK = bunx tsc --noEmit
 FORMAT = bunx biome format --write
-LINT = bunx biome check --diagnostic-level=error --write --unsafe
+LINT = bunx biome check --write
 TEST = bun test
 
 .PHONY: all typecheck test-typeschema test-register test-codegen test-typescript-r4-example

biome.json

@@ -42,7 +42,7 @@
         "noExcessiveCognitiveComplexity": {
           "level": "warn",
           "options": {
-            "maxAllowedComplexity": 50
+            "maxAllowedComplexity": 39
           }
         }
       },

examples/typescript-r4/demo.ts

@@ -276,14 +276,15 @@ function runDemo() {
     const patient = createPatient();
     console.log("✓ Created patient:", patient.id);
 
-    const observation = createObservation(patient.id!);
+    if (!patient.id) throw new Error("Failed to create patient");
+    const observation = createObservation(patient.id);
     console.log("✓ Created glucose observation:", observation.id);
 
     console.log(`\n${"=".repeat(60)}`);
     console.log("Bodyweight profile attach/extract demo:");
     console.log("=".repeat(60));
 
-    const bodyweightObs = createBodyWeightObservation(patient.id!);
+    const bodyweightObs = createBodyWeightObservation(patient.id);
     console.log("✓ Created body weight observation with profile:", bodyweightObs.id);
 
     const bundle = createBundle(patient, observation, bodyweightObs);

src/api/writer-generator/typescript.ts

@@ -275,6 +275,7 @@ export class TypeScript extends Writer<TypeScriptOptions> {
                 if (field.enum) {
                     tsType = tsEnumType(field.enum);
                 } else if (schema.identifier.name === "Reference" && tsName === "reference") {
+                    // biome-ignore lint: that is exactly string what we want
                     tsType = "`${T}/${string}`";
                 } else if (field.reference && field.reference.length > 0) {
                     const references = field.reference.map((ref) => `"${ref.name}"`).join(" | ");

src/cli/commands/generate.ts

@@ -119,13 +119,6 @@ export const generateCommand: CommandModule<Record<string, unknown>, GenerateArg
 
             // Configure generators from config
             if (config.typescript) {
-                if (verbose) {
-                    logger.info("Configuring TypeScript generation from config");
-                    logger.debug(`Module format: ${config.typescript.moduleFormat || "esm"}`);
-                    logger.debug(`Generate index: ${config.typescript.generateIndex ?? true}`);
-                    logger.debug(`Include docs: ${config.typescript.includeDocuments ?? false}`);
-                    logger.debug(`Naming convention: ${config.typescript.namingConvention || "PascalCase"}`);
-                }
                 throw new Error("Not Implemented");
             }
 

src/cli/commands/typeschema/generate.ts

@@ -126,7 +126,8 @@ export const generateTypeschemaCommand: CommandModule<Record<string, unknown>, G
             // Use the output format determined earlier
 
             // Ensure output directory exists
-            const outputPath = argv.output!;
+            const outputPath = argv.output;
+            if (!outputPath) throw new Error("Output format not specified");
             await mkdir(dirname(outputPath), { recursive: true });
 
             // Format and write the schemas

src/config.ts

@@ -731,7 +731,8 @@ export class ConfigLoader {
             }
 
             // Merge with defaults
-            return this.mergeWithDefaults(validation.config!);
+            if (!validation.config) throw new Error("Invalid configuration");
+            return this.mergeWithDefaults(validation.config);
         } catch (error) {
             if (error instanceof Error) {
                 throw new Error(`Failed to load config from ${filePath}: ${error.message}`);

src/typeschema/core/field-builder.ts

@@ -14,7 +14,8 @@ import { mkBindingIdentifier, mkIdentifier } from "./identifier";
 import { mkNestedIdentifier } from "./nested-types";
 
 function isRequired(register: Register, fhirSchema: RichFHIRSchema, path: string[]): boolean {
-    const fieldName = path[path.length - 1]!;
+    const fieldName = path[path.length - 1];
+    if (!fieldName) throw new Error(`Internal error: fieldName is missing for path ${path.join("/")}`);
     const parentPath = path.slice(0, -1);
 
     const requires = register.resolveFsGenealogy(fhirSchema.package_meta, fhirSchema.url).flatMap((fs) => {
@@ -116,7 +117,7 @@ export const mkField = (
     if (!fieldType)
         logger?.warn(`Field type not found for '${fhirSchema.url}#${path.join(".")}' (${fhirSchema.derivation})`);
     return {
-        type: fieldType!,
+        type: fieldType as Identifier,
         required: isRequired(register, fhirSchema, path),
         excluded: isExcluded(register, fhirSchema, path),
 

src/typeschema/core/nested-types.ts

@@ -116,7 +116,7 @@ export function mkNestedTypes(
             url: baseUrl,
         };
 
-        const fields = transformNestedElements(register, fhirSchema, path, element.elements!, logger);
+        const fields = transformNestedElements(register, fhirSchema, path, element.elements ?? {}, logger);
 
         const nestedType: NestedType = {
             identifier,

src/typeschema/types.ts

@@ -344,7 +344,7 @@ type ValueSetCompose = {
     include: {
         concept?: Concept[];
         system?: string;
-        filter?: {}[];
+        filter?: unknown[];
     }[];
 };