Skip to content

Typings incomplete / using any instead of type #557

@MJLHThomassen-Sorama

Description

@MJLHThomassen-Sorama

I'm submitting a bug report

  • Library Version:
    2.0.0-rc2

Please tell us about your environment:

  • Operating System:
    Windows 10

  • Node Version:
    v14.15.5

  • NPM Version:
    6.14.8

  • Browser:
    all

  • Language:
    TypeScript

Current behavior:

In the aurelia-validation.d.ts file currently there this bit of code:

export declare class ValidationRules {
	private static parsers;
	static initialize(messageParser: ValidationMessageParser, propertyParser: PropertyAccessorParser): void;
	/**
	 * Target a property with validation rules.
	 * @param property The property to target. Can be the property name or a property accessor function.
	 */
	static ensure<TObject, TValue>(property: string | number | PropertyAccessor<TObject, TValue>): FluentRules<TObject, any>;

The ensure() method returns a FluentRules<TObject, any>, wile i would expect it to return a FluentRules<TObject, TValue>.
The FluentRules class is fully typed properly with the TValue parameter, but all instances of FluentRules specify "any" as the second type parameter which cancels all the nice typescript benefits of type checking on the value.

Expected/desired behavior:
All methods that return a FluentRules have it properly typed, 'any' is not used.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions