UPSTREAM PR #2532: Use GIX_TEST_FIXTURE_HASH for gix-diff#49
Open
loci-dev wants to merge 8 commits into
Open
Conversation
This fixes the following warning: ``` warning: profiles for the non root package will be ignored, specify profiles at the workspace root: package: .../gix-imara-diff/Cargo.toml workspace: .../Cargo.toml ```
Collapse match as the two branches are not identical as they should have been from the start.
|
The analysis encountered an error. Please review the Processing Details for more information. |
1 similar comment
|
The analysis encountered an error. Please review the Processing Details for more information. |
loci-dev
force-pushed
the
main
branch
3 times, most recently
from
c6739bc to
6f67b12
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: GitoxideLabs/gitoxide#2532
This is a follow-up to #2497 which made tests in
gix-diff-testsrun withGIX_TEST_FIXTURE_HASH=sha256.This PR adds:
Remove
profile.releasesection ingix-imara-diffThis fixes the following warning:
There’s also a commented out
[[bench]]section ingix-imara-diff/Cargo.tomlthat could be removed as well.Run
gix-diff-testswithGIX_TEST_FIXTURE_HASH=sha1as well (before, they were only run withGIX_TEST_FIXTURE_HASH=sha256)Use
GIX_TEST_FIXTURE_HASHforgix-diffas well (as opposed togix-diff-testswhich is a separate crate)