UPSTREAM PR #30810: Add support for HSS signature verification.#682
Open
loci-dev wants to merge 2 commits into
Open
UPSTREAM PR #30810: Add support for HSS signature verification.#682loci-dev wants to merge 2 commits into
loci-dev wants to merge 2 commits into
Conversation
This is an extension of LMS with multile levels of trees. Since the OID is shared between HSS and LMS the existing LMS keymanager has been extended to support both. LMS is just HSS with one tree level. The public key for HSS has 4 additional bytes indicating the number of trees (L). In raw form a LMS public key may optionally have the extra header for L with a value or 1.
|
No meaningful performance changes were detected across 20082 analyzed functions in the following binaries: libcrypto.so, libssl.so, openssl. 💬 Questions? Tag @loci-dev |
loci-dev
force-pushed
the
main
branch
4 times, most recently
from
421b135 to
770bf14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: openssl/openssl#30810
This is an extension of LMS with multile levels of trees. Since the OID is shared between HSS and LMS the existing LMS keymanager has been extended to support both. LMS is just HSS with one tree level. The public key for HSS has 4 additional bytes to the number of trees (L). In raw form a LMS public key may optionally have the extra header for L with a value or 1.
Previous attempts at this PR only handled XDR raw format and had a separate keymanager for HSS. This was before I was aware of the SubjectPublicKeyInfo format which has a combined HSS_LMS OID.
Checklist