UPSTREAM PR #30988: test: respect disabled IPv6 in bio_tfo_test#688
Open
loci-dev wants to merge 1 commit into
Open
UPSTREAM PR #30988: test: respect disabled IPv6 in bio_tfo_test#688loci-dev wants to merge 1 commit into
loci-dev wants to merge 1 commit into
Conversation
|
No meaningful performance changes were detected across 20081 analyzed functions in the following binaries: libcrypto.so, libssl.so, openssl. 💬 Questions? Tag @loci-dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: openssl/openssl#30988
bio_tfo_testcan select IPv6 addresses even when OpenSSL is built with-DOPENSSL_USE_IPV6=0.In particular, the raw FD test uses
getaddrinfowith AF_UNSPEC, so it may receive an AF_INET6 address. That address is then rejected byBIO_ADDR_rawmakebecause IPv6 support was compiled out.Fixes #30975
Verified with:
./Configure linux-x86_64 shared enable-tfo enable-unit-test no-fips -DOPENSSL_USE_IPV6=0 make -j4 test TESTS=test_bio_tfo V=1Result: PASS. The FD subtest used IPv4.
Checklist