UPSTREAM PR #30857: Add stack test for thunked sorted lookup#689
Open
loci-dev wants to merge 1 commit into
Open
UPSTREAM PR #30857: Add stack test for thunked sorted lookup#689loci-dev wants to merge 1 commit into
loci-dev wants to merge 1 commit into
Conversation
loci-dev
had a problem deploying
to
PROD__AL_DEMO
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Source pull request: openssl/openssl#30857
Add coverage for sorted lookup on a typed stack that has a generated comparison thunk installed.
The
ucharstack test already constructs a typed stack withsk_uchar_new(&uchar_compare), which installs the generated safestack comparison thunk.This change extends that test to sort a duplicated stack and then verify that
sk_uchar_findcan locate each value.Rationale
Typed stacks created through
sk_TYPE_new(cmp)install a comparison thunk used by stack lookup paths. This test documents that the generated thunk path remains compatible with sorted lookup aftersk_TYPE_sort.Testing
Tested the same change in configured build trees on Windows and Linux.
Windows, VC-WIN64A:
.\test\stack_test.exenmake test TESTS=test_stackLinux, Ubuntu 24.04 x64:
./test/stack_testmake test TESTS=test_stack