I don't think we need to change this right now, but I think we should probably move [cluster management] regions to Github secrets/variables to avoid duplication between this file and the examples themselves.
Originally posted by @mitchell-elholm in #144 (comment)
There are several places where we reference the regions us-east-1 and us-east-2 in the context of the cluster management examples. We are currently choosing to run the tests for all languages against these regions, but may want to change that in the future.
We should define these regions using secrets/variables in the workflow files, so we can easily change them and centralize their definition.
Places to update:
- Workflow files
clean-cluster.sh script- Cluster management tests
The cluster management tests allow configuration through environment variables in most cases. We may need to double check that they all do, but if not this should be a small change. Then we can configure the regions to use environment variables in the workflows for the test runs.
Originally posted by @mitchell-elholm in #144 (comment)
There are several places where we reference the regions
us-east-1andus-east-2in the context of the cluster management examples. We are currently choosing to run the tests for all languages against these regions, but may want to change that in the future.We should define these regions using secrets/variables in the workflow files, so we can easily change them and centralize their definition.
Places to update:
clean-cluster.shscriptThe cluster management tests allow configuration through environment variables in most cases. We may need to double check that they all do, but if not this should be a small change. Then we can configure the regions to use environment variables in the workflows for the test runs.