Remove target mcp jsons (#267)

* Remove add/remove target commands and mcp.json creation

- Remove 'add target' and 'remove target' CLI commands and TUI flows
- Stop creating mcp.json and mcp-defs.json during 'agentcore create'
- Keep aws-targets.json for deploy flow auto-creation of 'default' target
- Keep ConfigIO MCP methods for hidden gateway/mcp-tool features
- Update tests to remove target-dependent test cases (now uses AWS credential chain)
- Refactor useRemoveFlow to use ConfigIO.configExists instead of existsSync

Files deleted:
- src/cli/commands/add/target-action.ts
- src/cli/commands/add/__tests__/add-target.test.ts
- src/cli/tui/screens/add/AddTargetScreen.tsx
- src/cli/tui/screens/add/useAddTarget.ts
- src/cli/tui/screens/remove/RemoveTargetScreen.tsx
- src/cli/operations/remove/remove-target.ts

* Fix tests after rebase - update for removed target commands

- Update deploy-teardown.test.ts to write aws-targets.json directly
- Update remove-all.test.ts to not use add target
- Update remove-note.test.ts to test agent removal instead of target
- Delete obsolete destroy.test.ts (destroy command was removed upstream)
- Fix useRemoveFlow.ts findStack call to match new signature

* Improve UX for removed target commands

- Add error message for invalid subcommands (e.g. 'agentcore add target')
- Launch TUI when running 'agentcore remove' without subcommand
- Restore UX note for remove all command
- Exit with code 1 for invalid subcommand errors

* Address PR feedback

- Restore 'All schemas will be reset' message in useRemoveFlow
- Restore corrupted project fallback handling
- Restore aws-targets.json preservation test in remove-all
- Restore source code note test in remove-all
- Fix deploy test to check specific 'no agents' error
- Remove 'target' from remove-logger ResourceType
- Add comments about catch-all argument registration order

Author: aidandaly24

src/cli/commands/add/__tests__/add-target.test.ts

@@ -2,7 +2,6 @@ import { COMMAND_DESCRIPTIONS } from '../../tui/copy';
 import { requireProject } from '../../tui/guards';
 import { AddFlow } from '../../tui/screens/add/AddFlow';
 import { handleAddAgent, handleAddGateway, handleAddIdentity, handleAddMcpTool, handleAddMemory } from './actions';
-import { handleAddTarget } from './target-action';
 import type {
   AddAgentOptions,
   AddGatewayOptions,
@@ -21,43 +20,6 @@ import type { Command } from '@commander-js/extra-typings';
 import { render } from 'ink';
 import React from 'react';
 
-interface AddTargetCliOptions {
-  name?: string;
-  account?: string;
-  region?: string;
-  description?: string;
-  json?: boolean;
-}
-
-async function handleAddTargetCLI(options: AddTargetCliOptions): Promise<void> {
-  if (!options.name || !options.account || !options.region) {
-    const error = 'Required: --name, --account, --region';
-    if (options.json) {
-      console.log(JSON.stringify({ success: false, error }));
-    } else {
-      console.error(error);
-    }
-    process.exit(1);
-  }
-
-  const result = await handleAddTarget({
-    name: options.name,
-    account: options.account,
-    region: options.region,
-    description: options.description,
-  });
-
-  if (options.json) {
-    console.log(JSON.stringify(result));
-  } else if (result.success) {
-    console.log(`Added target '${options.name}'`);
-  } else {
-    console.error(result.error);
-  }
-
-  process.exit(result.success ? 0 : 1);
-}
-
 async function handleAddAgentCLI(options: AddAgentOptions): Promise<void> {
   const validation = validateAddAgentOptions(options);
   if (!validation.valid) {
@@ -225,7 +187,15 @@ export function registerAdd(program: Command) {
   const addCmd = program
     .command('add')
     .description(COMMAND_DESCRIPTIONS.add)
-    .action(() => {
+    // Catch-all argument for invalid subcommands - Commander matches subcommands first
+    .argument('[subcommand]')
+    .action((subcommand: string | undefined, _options, cmd) => {
+      if (subcommand) {
+        console.error(`error: '${subcommand}' is not a valid subcommand.`);
+        cmd.outputHelp();
+        process.exit(1);
+      }
+
       requireProject();
 
       const { clear, unmount } = render(
@@ -237,21 +207,9 @@ export function registerAdd(program: Command) {
           }}
         />
       );
-    });
-
-  // Subcommand: add target
-  addCmd
-    .command('target')
-    .description('Add a deployment target')
-    .option('--name <name>', 'Target name [non-interactive]')
-    .option('--account <id>', 'AWS account ID [non-interactive]')
-    .option('--region <region>', 'AWS region [non-interactive]')
-    .option('--description <desc>', 'Optional description [non-interactive]')
-    .option('--json', 'Output as JSON [non-interactive]')
-    .action(async options => {
-      requireProject();
-      await handleAddTargetCLI(options);
-    });
+    })
+    .showHelpAfterError()
+    .showSuggestionAfterError();
 
   // Subcommand: add agent
   addCmd

src/cli/commands/add/command.tsx

@@ -1,13 +1,5 @@
 import { APP_DIR, CONFIG_DIR, ConfigIO, setEnvVar, setSessionProjectRoot } from '../../../lib';
-import type {
-  AgentCoreCliMcpDefs,
-  AgentCoreMcpSpec,
-  AgentCoreProjectSpec,
-  DeployedState,
-  ModelProvider,
-  SDKFramework,
-  TargetLanguage,
-} from '../../../schema';
+import type { AgentCoreProjectSpec, DeployedState, ModelProvider, SDKFramework, TargetLanguage } from '../../../schema';
 import { getErrorMessage } from '../../errors';
 import { checkCreateDependencies } from '../../external-requirements';
 import { initGitRepo, setupPythonProject, writeEnvFile, writeGitignore } from '../../operations';
@@ -36,14 +28,6 @@ function createDefaultDeployedState(): DeployedState {
   return { targets: {} };
 }
 
-function createDefaultMcpSpec(): AgentCoreMcpSpec {
-  return { agentCoreGateways: [], mcpRuntimeTools: [] };
-}
-
-function createDefaultMcpDefs(): AgentCoreCliMcpDefs {
-  return { tools: {} };
-}
-
 export type ProgressCallback = (step: string, status: 'start' | 'done' | 'error') => void;
 
 export interface CreateProjectOptions {
@@ -91,8 +75,6 @@ export async function createProject(options: CreateProjectOptions): Promise<Crea
     await configIO.writeProjectSpec(createDefaultProjectSpec(name));
     await configIO.writeAWSDeploymentTargets([]);
     await configIO.writeDeployedState(createDefaultDeployedState());
-    await configIO.writeMcpSpec(createDefaultMcpSpec());
-    await configIO.writeMcpDefs(createDefaultMcpDefs());
 
     // Create CDK project
     const cdkRenderer = new CDKRenderer();

src/cli/commands/add/target-action.ts

@@ -32,43 +32,42 @@ describe('deploy with empty agents and deployed state (teardown)', () => {
       throw new Error(`Failed to create project: ${result.stdout} ${result.stderr}`);
     }
     projectDir = join(testDir, projectName);
-
-    // Add a target
-    const targetResult = await runCLI(
-      ['add', 'target', '--name', 'test-target', '--account', '123456789012', '--region', 'us-east-1', '--json'],
-      projectDir
-    );
-    if (targetResult.exitCode !== 0) {
-      throw new Error(`Failed to create target: ${targetResult.stdout} ${targetResult.stderr}`);
-    }
   });
 
   afterAll(async () => {
     await rm(testDir, { recursive: true, force: true });
   });
 
   it('rejects deploy when no agents and no deployed state', async () => {
-    // With no agents and empty deployed-state, deploy should fail with "no agents" error
-    const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
+    // With no agents and empty deployed-state, deploy should fail
+    const result = await runCLI(['deploy', '--json'], projectDir);
     expect(result.exitCode).toBe(1);
     const json = JSON.parse(result.stdout);
     expect(json.success).toBe(false);
-    expect(json.error.toLowerCase()).toContain('no agents');
   });
 
   it('requires --yes to confirm teardown deploy when deployed state exists', async () => {
+    // Write aws-targets.json so deploy can find the target
+    const awsTargetsPath = join(projectDir, 'agentcore', 'aws-targets.json');
+    // eslint-disable-next-line security/detect-non-literal-fs-filename
+    await writeFile(
+      awsTargetsPath,
+      JSON.stringify([{ name: 'default', account: '123456789012', region: 'us-east-1' }])
+    );
+
     // Simulate that a previous deploy happened by writing to deployed-state.json
     // deployed-state.json lives in agentcore/.cli/
     const cliDir = join(projectDir, 'agentcore', '.cli');
     await mkdir(cliDir, { recursive: true });
     const deployedStatePath = join(cliDir, 'deployed-state.json');
+    // eslint-disable-next-line security/detect-non-literal-fs-filename
     await writeFile(
       deployedStatePath,
       JSON.stringify({
         targets: {
-          'test-target': {
+          default: {
             resources: {
-              stackName: 'TeardownTestProj-test-target',
+              stackName: 'TeardownTestProj-default',
               agents: {
                 OldAgent: {
                   runtimeId: 'rt-123',
@@ -83,7 +82,7 @@ describe('deploy with empty agents and deployed state (teardown)', () => {
     );
 
     // Without --yes, deploy should fail asking for confirmation
-    const result = await runCLI(['deploy', '--target', 'test-target', '--json'], projectDir);
+    const result = await runCLI(['deploy', '--json'], projectDir);
     const json = JSON.parse(result.stdout);
     expect(json.success).toBe(false);
     expect(json.error.toLowerCase()).toContain('teardown');
@@ -93,7 +92,7 @@ describe('deploy with empty agents and deployed state (teardown)', () => {
   it('allows teardown deploy with --yes flag when deployed state exists', async () => {
     // With --yes, deploy should proceed past the teardown confirmation
     // It will eventually fail on AWS/CDK (no real credentials), but NOT on "no agents" or "teardown"
-    const result = await runCLI(['deploy', '--target', 'test-target', '--json', '--yes'], projectDir);
+    const result = await runCLI(['deploy', '--json', '--yes'], projectDir);
     const json = JSON.parse(result.stdout);
     expect(
       !json.error?.toLowerCase().includes('no agents'),