From 209b5436b9cc917b2bbc1bb5ed2d401bd8ae4bd9 Mon Sep 17 00:00:00 2001
From: user <magi@magi-desktop>
Date: Tue, 2 Jun 2020 13:40:28 +0900
Subject: [PATCH 1/4] add test script

---
 test_utils.py | 6 ++++++
 1 file changed, 6 insertions(+)
 create mode 100644 test_utils.py

diff --git a/test_utils.py b/test_utils.py
new file mode 100644
index 0000000..8631581
--- /dev/null
+++ b/test_utils.py
@@ -0,0 +1,6 @@
+import utils
+
+region = 'ap-northeast-1'
+standard_resource = 'arn:aws:securityhub:::ruleset/pci-dss/v/3.2.1'
+
+print(utils.get_standard_arn_for_region_and_resource(region, standard_resource))

From be56527af8701c477208180027de9e6968e4b72a Mon Sep 17 00:00:00 2001
From: user <magi@magi-desktop>
Date: Tue, 2 Jun 2020 13:44:58 +0900
Subject: [PATCH 2/4] add test script

---
 utils.py | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/utils.py b/utils.py
index cdb2fd4..9013ea7 100644
--- a/utils.py
+++ b/utils.py
@@ -5,4 +5,8 @@ def get_standard_arn_for_region_and_resource(region, standard_resource):
     if standard_resource == CIS_STANDARD_ARN or standard_resource == CIS_STANDARD_RESOURCE:
         return CIS_STANDARD_ARN
     else:
-        return 'arn:{partition}:securityhub:{region}::{resource}'.format(partition='aws', region=region, resource=standard_resource)
+        return 'arn:{partition}:securityhub:{region}::{resource}'.format(
+            partition='aws',
+            region=region,
+            resource=standard_resource.spit(':').pop()
+        )

From a742fed11bb3fd981ab1b740d1eda6ff0b862114 Mon Sep 17 00:00:00 2001
From: user <magi@magi-desktop>
Date: Tue, 2 Jun 2020 14:29:26 +0900
Subject: [PATCH 3/4] ensure proper arn format for non-CIS stardards

---
 utils.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/utils.py b/utils.py
index 9013ea7..bcce385 100644
--- a/utils.py
+++ b/utils.py
@@ -1,6 +1,6 @@
 CIS_STANDARD_RESOURCE = 'ruleset/cis-aws-foundations-benchmark/v/1.2.0'
 CIS_STANDARD_ARN = 'arn:aws:securityhub:::ruleset/cis-aws-foundations-benchmark/v/1.2.0'
-"arn:aws:securityhub:us-west-2::standards/pci-dss/v/3.2.1"
+#"arn:aws:securityhub:us-west-2::standards/pci-dss/v/3.2.1"
 def get_standard_arn_for_region_and_resource(region, standard_resource):
     if standard_resource == CIS_STANDARD_ARN or standard_resource == CIS_STANDARD_RESOURCE:
         return CIS_STANDARD_ARN
@@ -8,5 +8,5 @@ def get_standard_arn_for_region_and_resource(region, standard_resource):
         return 'arn:{partition}:securityhub:{region}::{resource}'.format(
             partition='aws',
             region=region,
-            resource=standard_resource.spit(':').pop()
+            resource=standard_resource.split(':').pop()
         )

From 63ea379fdc63c680b60c47f0ac12d4c2f4cef129 Mon Sep 17 00:00:00 2001
From: user <magi@magi-desktop>
Date: Tue, 2 Jun 2020 14:42:23 +0900
Subject: [PATCH 4/4] remove test script

---
 test_utils.py | 6 ------
 1 file changed, 6 deletions(-)
 delete mode 100644 test_utils.py

diff --git a/test_utils.py b/test_utils.py
deleted file mode 100644
index 8631581..0000000
--- a/test_utils.py
+++ /dev/null
@@ -1,6 +0,0 @@
-import utils
-
-region = 'ap-northeast-1'
-standard_resource = 'arn:aws:securityhub:::ruleset/pci-dss/v/3.2.1'
-
-print(utils.get_standard_arn_for_region_and_resource(region, standard_resource))