Skip to content

Conversation

@rorshan
Copy link
Contributor

@rorshan rorshan commented Dec 7, 2025

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Fixes incorrect quest requirement and adds missing whisper from Mage-Lieutenant Malister

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Alliance character

  1. .go quest starter 11231
  2. Check that Mage-Lieutenant Malister does not offer Sleeping Giants
  3. Complete Of Keys and Cages .quest add 11231 .quest complete 11231
  4. Turn in Of Keys and Cages at Father Levariol
  5. Check that Mage-Lieutenant whispers you: "$n, I would have words with you."
  6. Check that Mage-Lieutenant offers Sleeping Giants

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@rorshan rorshan marked this pull request as ready for review December 8, 2025 10:49
@TheSCREWEDSoftware TheSCREWEDSoftware added run-build Used to trigger the windows/mac/docker and matrix builds and removed run-build Used to trigger the windows/mac/docker and matrix builds labels Dec 8, 2025
Co-authored-by: Ryan Turner <16946913+TheSCREWEDSoftware@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Quest Sleeping Giants has wrong prerequisite [Howling Fjord][Quest] Sleeping Giants has wrong prerequisite

2 participants