Skip to content

Conversation

@TheSCREWEDSoftware
Copy link
Contributor

@TheSCREWEDSoftware TheSCREWEDSoftware commented Dec 8, 2025

This PR
image

Current AC
image

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

Issues Addressed:

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added the CORE Related to the core label Dec 8, 2025
@TheSCREWEDSoftware
Copy link
Contributor Author

@ovv any correctiosn are needed?

@sudlud
Copy link
Member

sudlud commented Dec 8, 2025

issue here currently is that @ovv mentioned this functionality is probably not working at all on authserver as of now. so what about adding the value plus the comment that it's a worldserver feature, non-functional as of now for authserver and is just placed there to fix the startup warning for now.
let's see what @ovv has to say

@ovv
Copy link
Contributor

ovv commented Dec 8, 2025

I haven't tested it with the authserver. Maybe it's working, maybe it's not.

If nobody does it first I plan to test it and make it work for the authserver when I find the time

In the meantime, if there is an easy way to skip this configuration for the authserver maybe that's the best first step. I'm not familiar enough with the codebase to know if something like that already exist. Otherwise what @sudlud proposed is fine with me, whatever is easier for the project.

# the server will use the socket passed by systemd instead of
# creating and binding its own listening socket. Disabled by default.
#
# When enabled the realm is not automatically set as offline on shutdown.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't applicable to the authserver

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CORE Related to the core Ready to be Reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auth server starts complains about missing property

3 participants