From 4b237280b60ce6b2c1c8c5bfe6ddf1226026d363 Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Tue, 14 Jul 2026 15:48:59 +0100
Subject: [PATCH 1/6] Set robotframework --exitonfailure flag by default.

---
 .github/actions/test/action.yml | 7 +++++++
 bin/run-tests                   | 6 ++++++
 2 files changed, 13 insertions(+)

diff --git a/.github/actions/test/action.yml b/.github/actions/test/action.yml
index 9ff1e41d..1310fae5 100644
--- a/.github/actions/test/action.yml
+++ b/.github/actions/test/action.yml
@@ -10,6 +10,11 @@ inputs:
     description: The name to use for the debug bundle artifact.
     required: true
     default: debug-bundle
+  exit-on-failure:
+    description: If true, robot will exit the tests as soon as the first failure occurs.
+    required: false
+    default: true
+    type: boolean
 runs:
   using: composite
   steps:
@@ -44,6 +49,8 @@ runs:
 
     - name: Run test suite
       shell: bash
+      env:
+        EXIT_ON_FAILURE: ${{ inputs.exit-on-failure }}
       run: |
         set -e
         source ./ci.env
diff --git a/bin/run-tests b/bin/run-tests
index b160ef4d..b4c11401 100755
--- a/bin/run-tests
+++ b/bin/run-tests
@@ -22,6 +22,11 @@ ansible_variable() {
 work_bin_dir="$(ansible_variable work_directory)/bin"
 export PATH=$PATH:$work_bin_dir
 
+extraargs=()
+if [[ $EXIT_ON_FAILURE == true ]]; then
+    extraargs+=(--exitonfailure)
+fi
+
 # Get the test directory
 test_directory="$(ansible_variable generate_tests_suite_directory)"
 test_vars_file="$(ansible_variable generate_tests_vars_file)"
@@ -32,5 +37,6 @@ exec robot \
   --loglevel debug \
   --consolecolors on \
   --variablefile "$test_vars_file" \
+  "$extraargs" \
   "$@" \
   "$test_directory"

From 9c4cbb54c93bf8a5ceff33e9a20a2c746a61c5eb Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Tue, 14 Jul 2026 16:14:42 +0100
Subject: [PATCH 2/6] Github actions lint error.

---
 .github/actions/test/action.yml | 1 -
 1 file changed, 1 deletion(-)

diff --git a/.github/actions/test/action.yml b/.github/actions/test/action.yml
index 1310fae5..099b14df 100644
--- a/.github/actions/test/action.yml
+++ b/.github/actions/test/action.yml
@@ -14,7 +14,6 @@ inputs:
     description: If true, robot will exit the tests as soon as the first failure occurs.
     required: false
     default: true
-    type: boolean
 runs:
   using: composite
   steps:

From 0f11078485df2efae6b084ff6f2708d34cf99ba5 Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Tue, 14 Jul 2026 16:26:33 +0100
Subject: [PATCH 3/6] Don't use bash array expansion.

---
 bin/run-tests | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/bin/run-tests b/bin/run-tests
index b4c11401..d5302459 100755
--- a/bin/run-tests
+++ b/bin/run-tests
@@ -22,9 +22,9 @@ ansible_variable() {
 work_bin_dir="$(ansible_variable work_directory)/bin"
 export PATH=$PATH:$work_bin_dir
 
-extraargs=()
+extraargs=""
 if [[ $EXIT_ON_FAILURE == true ]]; then
-    extraargs+=(--exitonfailure)
+    extraargs="--exitonfailure :$extraargs"
 fi
 
 # Get the test directory

From 57a88e27b1457f59cbdb43c6f1a3657fb8f3604a Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Tue, 14 Jul 2026 17:01:26 +0100
Subject: [PATCH 4/6] shfmt

---
 bin/run-tests | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/run-tests b/bin/run-tests
index d5302459..a8c5d906 100755
--- a/bin/run-tests
+++ b/bin/run-tests
@@ -24,7 +24,7 @@ export PATH=$PATH:$work_bin_dir
 
 extraargs=""
 if [[ $EXIT_ON_FAILURE == true ]]; then
-    extraargs="--exitonfailure :$extraargs"
+  extraargs="--exitonfailure :$extraargs"
 fi
 
 # Get the test directory

From ade4c8e00c39325e607a8cd3286e9342522fd31a Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Mon, 20 Jul 2026 09:41:33 +0100
Subject: [PATCH 5/6] Remove errant :

---
 bin/run-tests | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/run-tests b/bin/run-tests
index a8c5d906..ed74cf16 100755
--- a/bin/run-tests
+++ b/bin/run-tests
@@ -24,7 +24,7 @@ export PATH=$PATH:$work_bin_dir
 
 extraargs=""
 if [[ $EXIT_ON_FAILURE == true ]]; then
-  extraargs="--exitonfailure :$extraargs"
+  extraargs="--exitonfailure $extraargs"
 fi
 
 # Get the test directory

From 07cd23fdc47f97fc92c1b67818526b978979af81 Mon Sep 17 00:00:00 2001
From: Alex Manning <alexm@stackhpc.com>
Date: Wed, 22 Jul 2026 14:58:38 +0100
Subject: [PATCH 6/6] Quote.

---
 bin/run-tests | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/run-tests b/bin/run-tests
index ed74cf16..44b1fa15 100755
--- a/bin/run-tests
+++ b/bin/run-tests
@@ -37,6 +37,6 @@ exec robot \
   --loglevel debug \
   --consolecolors on \
   --variablefile "$test_vars_file" \
-  "$extraargs" \
+  $extraargs \
   "$@" \
   "$test_directory"