Skip to content

Commit df9515e

Browse files
authored
Update controller.go (#233)
1 parent d5f3614 commit df9515e

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pkg/controller/controller.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ func (r *PodReconciler) Reconcile(ctx context.Context, req ctrl.Request) (ctrl.R
7272
node := pod.Spec.NodeName
7373

7474
if pod.Status.Phase == corev1.PodSucceeded || pod.Status.Phase == corev1.PodFailed {
75-
if r.Controller.Config().SavePodLog && pod.DeletionTimestamp == nil {
75+
if r.Controller.Config().SavePodLog && r.Controller.Has(node, executionID) {
7676
r.savePodLogs(ctx, pod, executionID)
7777
}
7878
if err := r.Controller.PodTerminated(executionID, node, pod.Status.Phase); err != nil {

pkg/controller/controller_test.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -124,6 +124,7 @@ var _ = Describe("Controller", func() {
124124
It("should update controller on pod succeeded with logs of 2 containers", func() {
125125
cfg.SavePodLog = true
126126
mockController.EXPECT().Config().Return(cfg).AnyTimes()
127+
mockController.EXPECT().Has(gm.Any(), executionID).Return(true)
127128
mockSink.EXPECT().WithValues(gm.Any()).Return(mockSink).AnyTimes()
128129
mockSink.EXPECT().Info(gm.Any(), gm.Any()).AnyTimes()
129130
mockClient.EXPECT().Get(gm.Any(), gm.Any(), gm.AssignableToTypeOf(&corev1.Pod{})).

0 commit comments

Comments
 (0)