From 58bbc50ff6aa9a5af1fa432547c53ca855287fa9 Mon Sep 17 00:00:00 2001 From: faisalnugroho Date: Sun, 31 May 2026 00:06:46 +0800 Subject: [PATCH] fix(signer): throw error instead of returning in sendRequestToSubAccountSigner The catch block in sendRequestToSubAccountSigner used 'return' instead of 'throw' when handleAddSubAccountOwner failed. This caused the Error object to be silently returned as a value instead of propagating the error to the caller, masking sub-account owner addition failures. Closes #326 --- packages/account-sdk/src/sign/base-account/Signer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/account-sdk/src/sign/base-account/Signer.ts b/packages/account-sdk/src/sign/base-account/Signer.ts index 1cffe605..58ee5ad2 100644 --- a/packages/account-sdk/src/sign/base-account/Signer.ts +++ b/packages/account-sdk/src/sign/base-account/Signer.ts @@ -792,7 +792,7 @@ export class Signer { correlationId, errorMessage: parseErrorMessageFromAny(error), }); - return standardErrors.provider.unauthorized( + throw standardErrors.provider.unauthorized( 'failed to add sub account owner when sending request to sub account signer' ); }