From f51a154fc279dbb05c83db5757b7590603089a47 Mon Sep 17 00:00:00 2001 From: mehmetkr-31 Date: Tue, 2 Jun 2026 20:21:26 +0300 Subject: [PATCH 1/3] fix(account-sdk): remove broken require export conditions --- packages/account-sdk/package.json | 48 +++++++++++-------------------- 1 file changed, 16 insertions(+), 32 deletions(-) diff --git a/packages/account-sdk/package.json b/packages/account-sdk/package.json index 0faa2fff..b959c3dc 100644 --- a/packages/account-sdk/package.json +++ b/packages/account-sdk/package.json @@ -19,93 +19,77 @@ ".": { "types": "./dist/index.d.ts", "browser": { - "import": "./dist/index.js", - "require": "./dist/index.js" + "import": "./dist/index.js" }, "node": { - "import": "./dist/index.node.js", - "require": "./dist/index.node.js" + "import": "./dist/index.node.js" }, "default": "./dist/index.js" }, "./browser": { "types": "./dist/index.d.ts", - "import": "./dist/index.js", - "require": "./dist/index.js" + "import": "./dist/index.js" }, "./node": { "types": "./dist/index.node.d.ts", - "import": "./dist/index.node.js", - "require": "./dist/index.node.js" + "import": "./dist/index.node.js" }, "./payment/browser": { "types": "./dist/interface/payment/index.d.ts", - "import": "./dist/interface/payment/index.js", - "require": "./dist/interface/payment/index.js" + "import": "./dist/interface/payment/index.js" }, "./payment/node": { "types": "./dist/interface/payment/index.node.d.ts", - "import": "./dist/interface/payment/index.node.js", - "require": "./dist/interface/payment/index.node.js" + "import": "./dist/interface/payment/index.node.js" }, "./payment": { "types": "./dist/interface/payment/index.d.ts", "browser": { "types": "./dist/interface/payment/index.d.ts", - "import": "./dist/interface/payment/index.js", - "require": "./dist/interface/payment/index.js" + "import": "./dist/interface/payment/index.js" }, "node": { "types": "./dist/interface/payment/index.node.d.ts", - "import": "./dist/interface/payment/index.node.js", - "require": "./dist/interface/payment/index.node.js" + "import": "./dist/interface/payment/index.node.js" } }, "./spend-permission/browser": { "types": "./dist/interface/public-utilities/spend-permission/index.d.ts", - "import": "./dist/interface/public-utilities/spend-permission/index.js", - "require": "./dist/interface/public-utilities/spend-permission/index.js" + "import": "./dist/interface/public-utilities/spend-permission/index.js" }, "./spend-permission/node": { "types": "./dist/interface/public-utilities/spend-permission/index.node.d.ts", - "import": "./dist/interface/public-utilities/spend-permission/index.node.js", - "require": "./dist/interface/public-utilities/spend-permission/index.node.js" + "import": "./dist/interface/public-utilities/spend-permission/index.node.js" }, "./spend-permission": { "types": "./dist/interface/public-utilities/spend-permission/index.d.ts", "browser": { "types": "./dist/interface/public-utilities/spend-permission/index.d.ts", - "import": "./dist/interface/public-utilities/spend-permission/index.js", - "require": "./dist/interface/public-utilities/spend-permission/index.js" + "import": "./dist/interface/public-utilities/spend-permission/index.js" }, "node": { "types": "./dist/interface/public-utilities/spend-permission/index.node.d.ts", - "import": "./dist/interface/public-utilities/spend-permission/index.node.js", - "require": "./dist/interface/public-utilities/spend-permission/index.node.js" + "import": "./dist/interface/public-utilities/spend-permission/index.node.js" } }, "./prolink": { "types": "./dist/interface/public-utilities/prolink/index.d.ts", "browser": { "types": "./dist/interface/public-utilities/prolink/index.d.ts", - "import": "./dist/interface/public-utilities/prolink/index.js", - "require": "./dist/interface/public-utilities/prolink/index.js" + "import": "./dist/interface/public-utilities/prolink/index.js" }, "node": { "types": "./dist/interface/public-utilities/prolink/index.node.d.ts", - "import": "./dist/interface/public-utilities/prolink/index.node.js", - "require": "./dist/interface/public-utilities/prolink/index.node.js" + "import": "./dist/interface/public-utilities/prolink/index.node.js" }, "default": { "types": "./dist/interface/public-utilities/prolink/index.d.ts", - "import": "./dist/interface/public-utilities/prolink/index.js", - "require": "./dist/interface/public-utilities/prolink/index.js" + "import": "./dist/interface/public-utilities/prolink/index.js" } }, "./ui-assets": { "types": "./dist/ui/assets/index.d.ts", - "import": "./dist/ui/assets/index.js", - "require": "./dist/ui/assets/index.js" + "import": "./dist/ui/assets/index.js" } }, "files": [ From bc94457dcd03d9a81dde3c2923a8adbbae746319 Mon Sep 17 00:00:00 2001 From: mehmetkr-31 Date: Sat, 6 Jun 2026 22:19:56 +0300 Subject: [PATCH 2/3] fix(tests): isolate fake timers in createSmartAccount tests Move vi.useRealTimers() cleanup from beforeEach return callback to afterEach to ensure parallel test runs don't leave fake timer state polluted. Resolves Node v24 + Vitest timeout and AbortSignal issues. --- .../src/sign/base-account/utils/createSmartAccount.test.ts | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/packages/account-sdk/src/sign/base-account/utils/createSmartAccount.test.ts b/packages/account-sdk/src/sign/base-account/utils/createSmartAccount.test.ts index e84bef01..b3fac502 100644 --- a/packages/account-sdk/src/sign/base-account/utils/createSmartAccount.test.ts +++ b/packages/account-sdk/src/sign/base-account/utils/createSmartAccount.test.ts @@ -231,9 +231,10 @@ describe('getNonce', () => { beforeEach(() => { vi.useFakeTimers(); vi.setSystemTime(new Date(Date.UTC(2023, 1, 1))); - return () => { - vi.useRealTimers(); - }; + }); + + afterEach(() => { + vi.useRealTimers(); }); it('default', async () => { From eca5d3fd4f9bfd76b2ead08a625671aa5a0b5239 Mon Sep 17 00:00:00 2001 From: mehmetkr-31 Date: Sat, 6 Jun 2026 22:20:16 +0300 Subject: [PATCH 3/3] fix(signer): include method and subAccount address in error message Enriches the generic unauthorized error thrown when handleAddSubAccountOwner fails by adding the request method, subAccount address, and underlying error detail to the message. This makes debugging signer failures tractable for developers. --- packages/account-sdk/src/sign/base-account/Signer.ts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/account-sdk/src/sign/base-account/Signer.ts b/packages/account-sdk/src/sign/base-account/Signer.ts index 1cffe605..55faf538 100644 --- a/packages/account-sdk/src/sign/base-account/Signer.ts +++ b/packages/account-sdk/src/sign/base-account/Signer.ts @@ -787,13 +787,14 @@ export class Signer { }); logAddOwnerCompleted({ method: request.method, correlationId }); } catch (error) { + const errorDetail = parseErrorMessageFromAny(error); logAddOwnerError({ method: request.method, correlationId, - errorMessage: parseErrorMessageFromAny(error), + errorMessage: errorDetail, }); return standardErrors.provider.unauthorized( - 'failed to add sub account owner when sending request to sub account signer' + `failed to add sub account owner when sending ${request.method} to sub account signer (${subAccount.address}): ${errorDetail}` ); } }