improve CompletionBuilder spec

Author: DannyBen

lib/bashly.rb

@@ -6,8 +6,9 @@ module Bashly
   autoloads 'bashly/refinements', %i[ComposeRefinements]
 
   autoloads 'bashly', %i[
-    CLI Config ConfigValidator Library LibrarySource LibrarySourceConfig
-    MessageStrings RenderContext RenderSource Settings VERSION Watch
+    CLI CompletionBuilder Config ConfigValidator Library LibrarySource
+    LibrarySourceConfig MessageStrings RenderContext RenderSource Settings
+    VERSION Watch
   ]
 
   autoloads 'bashly/concerns', %i[

spec/approvals/completion_builder/aliases_and_global_flags

@@ -0,0 +1,25 @@
+---
+patterns:
+- cli [root options]
+- cli images|img [root_global options] [images options]
+- cli images|img list|ls [root_global options] [images_global options] [images_list
+  options]
+options:
+  root:
+  - "--help|-h"
+  - "--version|-v"
+  - "--debug"
+  root_global:
+  - "--debug"
+  images:
+  - "--help|-h"
+  - "--verbose"
+  images_global:
+  - "--verbose"
+  images_list:
+  - "--help|-h"
+  - "--env <env>"
+tokens:
+  env:
+  - prod
+  - dev

spec/approvals/completion_builder/root_options

@@ -0,0 +1,8 @@
+---
+patterns:
+- cli [root options]
+options:
+  root:
+  - "--help|-h"
+  - "--force|-f"
+  - "--verbose"

spec/approvals/completion_builder/source_resolution

@@ -0,0 +1,27 @@
+---
+patterns:
+- cli [root options]
+- cli upload [upload options] <source> <target> <extra>
+options:
+  root:
+  - "--help|-h"
+  - "--version|-v"
+  upload:
+  - "--help|-h"
+  - "--user|-u <user>"
+  - "--tag <tag>"
+tokens:
+  user:
+  - "+user"
+  tag:
+  source:
+  - "+directory"
+  - README.md
+  - "$(git branch)"
+  - "++literal"
+  target:
+  - "+file"
+  - README.md
+  extra:
+  - "+file"
+  - README.md

spec/approvals/completion_builder/token_collisions

@@ -0,0 +1,19 @@
+---
+patterns:
+- cli [root options] <root_file_3>
+options:
+  root:
+  - "--help|-h"
+  - "--version|-v"
+  - "--file <file>"
+  - "--root-file <root_file>"
+  - "--root-file-2 <root_file_2>"
+tokens:
+  file:
+  - one
+  root_file:
+  - two
+  root_file_2:
+  - three
+  root_file_3:
+  - four

spec/bashly/completion_builder_spec.rb

@@ -0,0 +1,19 @@
+describe CompletionBuilder do
+  fixtures = load_fixture('completion_builder')
+
+  describe '#call' do
+    fixtures.each do |fixture, options|
+      context "with :#{fixture}" do
+        let(:command) { Script::Command.new options['command'] }
+        let(:builder) do
+          described_class.new command, with_version: options.fetch('with_version', true)
+        end
+
+        it 'returns pattern config data' do
+          expect(builder.call.to_yaml)
+            .to match_approval("completion_builder/#{fixture}")
+        end
+      end
+    end
+  end
+end

spec/bashly/settings_spec.rb

@@ -103,6 +103,12 @@
     end
   end
 
+  describe '::argfile_var' do
+    it 'returns its default value' do
+      expect(subject.argfile_var).to eq 'ARGFILE'
+    end
+  end
+
   describe '::extra_lib_dirs' do
     context 'when set using env var as a comma delimited string' do
       before { ENV['BASHLY_EXTRA_LIB_DIRS'] = 'one,two' }

spec/fixtures/completion_builder.yml

@@ -0,0 +1,59 @@
+:root_options:
+  with_version: false
+  command:
+    name: cli
+    flags:
+    - long: --force
+      short: -f
+    - long: --verbose
+
+:source_resolution:
+  command:
+    name: cli
+    commands:
+    - name: upload
+      completions: [<file>, README.md]
+      args:
+      - name: source
+        completions: [<directory>, README.md, $(git branch), +literal]
+      - name: target
+      - name: extra
+      flags:
+      - long: --user
+        short: -u
+        arg: user
+        completions: [<user>]
+      - long: --tag
+        arg: tag
+
+:aliases_and_global_flags:
+  command:
+    name: cli
+    flags:
+    - long: --debug
+    commands:
+    - name: images
+      alias: img
+      flags:
+      - long: --verbose
+      commands:
+      - name: list
+        alias: ls
+        flags:
+        - long: --env
+          arg: env
+          allowed: [prod, dev]
+
+:token_collisions:
+  command:
+    name: cli
+    flags:
+    - long: --file
+      allowed: [one]
+    - long: --root-file
+      allowed: [two]
+    - long: --root-file-2
+      allowed: [three]
+    args:
+    - name: file
+      allowed: [four]