Skip to content

Conversation

@semohr
Copy link
Contributor

@semohr semohr commented Oct 20, 2025

  • Adds poethepoet as a task runner to simplify common dev commands.
  • Introduces uv and a uv.lock file for fast, reliable dependency management.
  • Implements a GitHub Actions workflow to automatically publish to PyPI

This is a continuation of #86

@github-actions
Copy link

Thank you for the PR! The changelog has not been updated, so here is a friendly reminder to check if you need to add an entry.

@snejus snejus requested a review from a team October 20, 2025 23:20
@snejus
Copy link
Member

snejus commented Oct 20, 2025

Can we have CI / packaging updates and internal restructuring split into two separate PRs to minimise any unintentional side effects?

@semohr
Copy link
Contributor Author

semohr commented Oct 20, 2025

What do you mean? There are two PRs. This one is based on #86, which is a minimal refactoring using the same build tools as before.

@snejus
Copy link
Member

snejus commented Oct 21, 2025

Ah I missed it! Jumped right into the diff, my bad 😅

@snejus
Copy link
Member

snejus commented Oct 25, 2025

OK I see where my confusion stems from - use cleanup as the base branch here!

@snejus snejus mentioned this pull request Oct 25, 2025
@JOJ0
Copy link
Member

JOJ0 commented Oct 28, 2025

OK I see where my confusion stems from - use cleanup as the base branch here!

You can change this with the "edit" button on top of the PR @semohr (since I recently was looking for that button too.... I thought I mention it ;-)

Screenshot 2025-10-28 at 12 52 38

@snejus
Copy link
Member

snejus commented Nov 17, 2025

Would you remind rebasing this on master?

To start with, I think it would be a good idea to copy/paste the same setup we use everywhere else (confuse has the most relevant one). Once we've got that in place, we can introduce uv - I specifically want to see what changes in comparison to our usual setup.

@semohr semohr force-pushed the release-flow branch 2 times, most recently from 6ab0e25 to 8e74d1a Compare November 17, 2025 16:06
@JOJ0 JOJ0 requested a review from snejus November 19, 2025 06:26
@JOJ0
Copy link
Member

JOJ0 commented Nov 20, 2025

Would you remind rebasing this on master?

To start with, I think it would be a good idea to copy/paste the same setup we use everywhere else (confuse has the most relevant one). Once we've got that in place, we can introduce uv - I specifically want to see what changes in comparison to our usual setup.

Ah ok, I finally read and actually understood that comment. So you want to use this repo's refactor as a test case for switching to uv everywhere, to then see the diff (kind of), thus a first step would be to set up the tooling here as we have it everywhere else first.

Ok, smart approach, @semohr do you want to set it up like that?

@semohr
Copy link
Contributor Author

semohr commented Nov 20, 2025

@JOJ0 I have seen this, just had not that much time recently.

Will hopefully have a look this weekend, I think we can cherry pick most things from here anyways. And just add a poetry lockfile. We use mostly the same setup just with uv instead of poetry here.

@codecov-commenter
Copy link

codecov-commenter commented Dec 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.26%. Comparing base (a602f02) to head (5bbb033).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #87   +/-   ##
=======================================
  Coverage   93.26%   93.26%           
=======================================
  Files          16       16           
  Lines         817      817           
  Branches      118      118           
=======================================
  Hits          762      762           
  Misses         35       35           
  Partials       20       20           

@Serene-Arc
Copy link

Ooh wonderful! I mentioned that I'd be willing to look into a uv conversion for beets, so this is great. We can test it out here and work out the bugs.

@semohr semohr mentioned this pull request Dec 7, 2025
3 tasks
@semohr
Copy link
Contributor Author

semohr commented Dec 7, 2025

This should also be mostly ready. I do not like that we have to prefix every command with uv run in the workflows tho. Would be nice to have a platform independent way to activate the environment :/

"Bug Tracker" = "https://github.com/beetbox/mediafile/issues"

[build-system]
requires = ["poetry-core"]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems a bit strange to me to still use the poetry build system. We should pick another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants