Update dependencies, modernize tox config, fix SQLAlchemy 1.4 incompatibilities#7
Merged
Merged
Conversation
binaryDiv
added
bug
ninanomenon
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the testing dependencies and GitHub Actions, and modernizes the tox configuration and other dev environment things.
While modernizing the tox configuration, I noticed that the constraints to run unit tests for both SQLAlchemy 1.4 and 2.0 didn't actually work. After fixing that, I noticed some incompatibilities with SQLAlchemy 1.4 (mainly: the
Queryclass wasn't generic yet, soQuery[T]raised an exception). Luckily, the fix for this was very simple (just put the type annotations in quotes).