Can "internal" and "omitted" events be merged?

[TheTechromancer]

This is an open question and may be an opportunity to consolidate and simplify the code.

[TheTechromancer]

"omit" excludes events from output based on these criteria:

• If its type is in omit_event_types e.g. DNS_NAME_UNRESOLVED

"internal" excludes events from output based on these criteria:

• If it's outside the scan's report_distance
• If it has a special URL extension

Additionally, "omit" gracefully removes the event from the discovery chain, preventing orphans.

I think the main reason these were separate is because even when an internal event leads to a discovery, there are cases where not all parent events are interesting. The biggest example is URL_UNVERIFIED. If a URL_UNVERIFIED leads to a URL, we still don't want to see it. That would be too much useless noise.

Therefore, the main difference between these two is that omit is a bit more forceful, and trumps internal. When a speculative event leads to a neat discovery, we want to retroactively resurrect some of its ancestors, but not all. internal tells us which events are speculative and not to output right away, and omit tells us which events are uninteresting to the user, and should not be output at all.