From f6305b967dc061e3dc3d39fa6e8845c78d78460d Mon Sep 17 00:00:00 2001
From: iroiro147 <sarthak.singh@juspay.in>
Date: Sat, 1 Aug 2026 17:41:06 +0530
Subject: [PATCH] fix(desktop): keep hover action bar & reaction pills out of
 text selection
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

macOS native text selection was slipping into message chrome: dragging
across a message would also select the hover action bar's labels and the
reaction pills' contents, and split view would let a drag hop from channel
content into thread content via the shared overlay context.

Mark the two interaction roots with `select-none` (and document why):

* `MessageActionBar` — the fading hover bar with quick reactions + menu
  trigger. Pure chrome; no user-visible text the reader needs to copy.
* `MessageReactions` — reaction pills + inline picker trigger. Pure chrome.

Together with the existing (native) behavior of `<button>` elements, this
closes the input surface for issue #4077 without changing any functionality:
message bodies, timestamps, and other metadata remain selectable; only the
overlaid interactive chrome is excluded from selection.

Manual macOS verification (per issue repro) would confirm the drag selection
now stops at the chrome boundaries the way other desktop messengers behave.

Fixes #4077

Signed-off-by: Sarthak Singh <sarthak.singh@juspay.in>
---
 desktop/src/features/messages/ui/MessageActionBar.tsx | 4 ++++
 desktop/src/features/messages/ui/MessageReactions.tsx | 4 ++++
 2 files changed, 8 insertions(+)

diff --git a/desktop/src/features/messages/ui/MessageActionBar.tsx b/desktop/src/features/messages/ui/MessageActionBar.tsx
index 967e50f5d2..39be0f7f5c 100644
--- a/desktop/src/features/messages/ui/MessageActionBar.tsx
+++ b/desktop/src/features/messages/ui/MessageActionBar.tsx
@@ -445,6 +445,10 @@ export const MessageActionBar = React.memo(function MessageActionBar({
         isReactionPickerOpen || isDropdownOpen
           ? "sm:pointer-events-auto sm:opacity-100"
           : "",
+        // Issue #4077: the hover action bar is chrome, not message content —
+        // it must not become part of the surrounding text selection when the
+        // user drag-selects across a message.
+        "select-none",
       )}
       data-testid={`message-action-bar-${message.id}`}
     >
diff --git a/desktop/src/features/messages/ui/MessageReactions.tsx b/desktop/src/features/messages/ui/MessageReactions.tsx
index 2250b3931f..5eb262b33b 100644
--- a/desktop/src/features/messages/ui/MessageReactions.tsx
+++ b/desktop/src/features/messages/ui/MessageReactions.tsx
@@ -247,6 +247,10 @@ export function MessageReactions({
     <div
       className={cn(
         "group/reactions mt-1.5 flex flex-wrap items-center gap-1.5",
+        // Issue #4077: reaction pills and the inline picker are chrome, not
+        // message content — they must not become part of the surrounding
+        // text selection when the user drag-selects across a message.
+        "select-none",
         className,
       )}
       data-testid="message-reactions"