Skip to content

CodeQL code-quality: empty except, unused import, implicit string concat in builder skills #106

Description

@risleylima

Summary

GitHub Code Quality (CodeQL analysis-kinds: code-quality) reports 5 open findings in BMad Builder Python skills after install into consumer repos (e.g. via _bmad / .agents/skills). These match the current main / v2.1.0 content.

Findings

Rule File Issue
py/implicit-string-concatenation-in-list (warning) skills/bmad-agent-builder/assets/init-sanctum-template.py ~170 Adjacent string literals in a list look like a missing comma
py/empty-except (note) skills/bmad-module-builder/scripts/scaffold-standalone-module.py ~144 except Exception: pass with no explanatory comment
py/empty-except (note) skills/bmad-agent-builder/scripts/render_report.py ~129 except OSError: pass with no comment
py/empty-except (note) skills/bmad-workflow-builder/scripts/render_report.py ~129 same (duplicated script)
py/unused-import (note) skills/bmad-workflow-builder/scripts/tests/test_canon_sync.py ~12 import sys unused

Expected

Skills that ship with BMad Builder should be CodeQL code-quality clean so consumer repos do not inherit false/noise findings in Security → Code quality.

Proposed fix

See upcoming PR: clarify intentional string join with +, add comments on intentional empty except, remove unused sys.

Environment

  • Reproduced from installed skills in a Nest/TS API repo using Code Quality on push
  • Compared hashes: local skills byte-identical to bmad-builder@main before fix

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions