Skip to content
This repository was archived by the owner on May 3, 2022. It is now read-only.
This repository was archived by the owner on May 3, 2022. It is now read-only.

Create an instance of the instrumented client per chart repository, and expose metrics per instrumented client #330

@parhamdoustdar

Description

@parhamdoustdar

Right now, we use the same instrumented client for all chart repositories. This is great because we expose some metrics about our requests to the chart repos, but it's not great because when these metrics change, we don't know which chart repository is acting up.

Using a different client per repositories allows us to be able to track these per repository, instead of globally. However, we will also need to register the metrics of each client as we construct a new Repository object.

This changes the structure a little bit because we don't register all our metrics in the very beginning just by calling instrumentedclient.GetMetrics() and registering the results. However, as chart repositories are discovered and constructed in runtime, there's no way to know and register these metrics ahead of time.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions