`EditMessageText` fails with `.result: Missing required field`

[makkarpov]

Subject line speaks it all, Circe decoder fails to parse a Telegram server response as the Message class.

Caused by: io.circe.DecodingFailure$DecodingFailureImpl: DecodingFailure at .result: Missing required field

Library version: 6.0.0

Offending response JSON

{
  "ok": true,
  "result": {
    "message_id": 5555,
    "from": {
      "id": 111111,
      "is_bot": true,
      "first_name": "Bot name",
      "username": "bot_username"
    },
    "chat": {
      "id": 222222,
      "first_name": "First",
      "last_name": "Last",
      "username": "username",
      "type": "private"
    },
    "date": 1763154244,
    "edit_date": 1763154257,
    "text": "Message text message text message text",
    "entities": [
      {
        "offset": 18,
        "length": 11,
        "type": "bold"
      },
      {
        "offset": 31,
        "length": 16,
        "type": "bold"
      }
    ],
    "reply_markup": {
      "inline_keyboard": [
        [
          {
            "text": "opt1",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/adj:0"
          },
          {
            "text": "opt2",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/adj:1"
          },
          {
            "text": "opt3",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/adj:2"
          }
        ],
        [
          {
            "text": "opt4",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/a"
          },
          {
            "text": "opt5",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/b"
          },
          {
            "text": "opt6",
            "callback_data": "dialog/942ffa64-692c-4680-ba0a-9ada8288ff40/c"
          }
        ]
      ]
    }
  }
}

The Message class itself is pretty weird. Decoder uses camel case fields all over the place, even though both encoder and Telegram API itself are using snake case. Yet it somehow works in other parts of the project, failing only in EditMessageText.

[ex0ns]

Thanks for opening the issue, I will see if I can reproduce using https://github.com/bot4s/telegram/blob/main/examples/src/SelfDestructBot.scala

Can you have a quick look at this example and let me know if you have something similar ?
I just ran a test on the SelfDestructBot and it worked as expected, can you share with me the usage of EditMessageText ?

[ex0ns]

@makkarpov about the Message class being weird, are you talking about this ?

telegram/core/src/com/bot4s/telegram/models/Message.scala

Lines 161 to 177 in 1c6e7a9

	final def apply(c: HCursor): Decoder.Result[Message] =
	for {
	messageId <- c.downField("messageId").as[Int]
	from <- c.getOrElse[Option[User]]("from")(None)
	date <- c.downField("date").as[Int]
	chat <- c.downField("chat").as[Chat]
	forwardFrom <- c.getOrElse[Option[User]]("forwardFrom")(None)
	forwardFromChat <- c.getOrElse[Option[Chat]]("forwardFromChat")(None)
	forwardFromMessageId <- c.getOrElse[Option[Int]]("forwardFromMessageId")(None)
	forwardSignature <- c.getOrElse[Option[String]]("forwardSignature")(None)
	forwardSenderName <- c.getOrElse[Option[String]]("forwardSenderName")(None)
	forwardDate <- c.getOrElse[Option[Int]]("forwardDate")(None)
	replyToMessage <- c.getOrElse[Option[Message]]("replyToMessage")(None)
	editDate <- c.getOrElse[Option[Int]]("editDate")(None)
	authorSignature <- c.getOrElse[Option[String]]("authorSignature")(None)
	text <- c.getOrElse[Option[String]]("text")(None)
	entities <- c.getOrElse[Option[Seq[MessageEntity]]]("entities")(None)

If yes, this is because we are not receiving message directly from the Telegram's API. We are receiving Update (through GetUpdates) and we read the message from it, but is has already been converted to camel case at this point in time.