fixup: feedback

Author: realark

py/src/braintrust/btx/conftest.py

@@ -142,6 +142,10 @@ def vcr_config() -> dict:
     return {
         "record_mode": record_mode,
         "decode_compressed_response": True,
+        # Match on method + URI + body: the request payload (model, messages, etc.)
+        # is what determines which cassette response is appropriate.
+        # Volatile per-version metadata lives in headers, not the body, so we strip
+        # those via filter_headers instead of dropping body from match_on.
         "match_on": ["method", "scheme", "host", "port", "path", "query", "body"],
         "filter_headers": [
             "authorization",
@@ -152,6 +156,19 @@ def vcr_config() -> dict:
             "openai-api-key",
             "x-goog-api-key",
             "x-bt-auth-token",
+            # Stainless SDK telemetry headers — version-specific, not part of the
+            # request semantics; strip so cassettes survive SDK version bumps.
+            "user-agent",
+            "User-Agent",
+            "x-stainless-arch",
+            "x-stainless-async",
+            "x-stainless-lang",
+            "x-stainless-os",
+            "x-stainless-package-version",
+            "x-stainless-runtime",
+            "x-stainless-runtime-version",
+            "x-stainless-read-timeout",
+            "x-stainless-retry-count",
         ],
     }
 

py/src/braintrust/btx/test_btx.py

@@ -49,12 +49,23 @@ def _load_specs() -> list[LlmSpanSpec]:
         spec_root = _SPEC_CACHE_DIR / ref / "test" / "llm_span"
 
     if not spec_root.exists():
-        return []
+        raise FileNotFoundError(
+            f"BTX spec root not found: {spec_root}\n"
+            "This module must be collected after conftest.py's pytest_configure hook "
+            "has run (which sets BTX_SPEC_ROOT). If you are seeing this error, "
+            "try running via pytest rather than importing directly."
+        )
     return load_specs(spec_root=spec_root, providers=_SUPPORTED_PROVIDERS)
 
 
 _all_specs: list[LlmSpanSpec] = _load_specs()
 
+if not _all_specs:
+    raise RuntimeError(
+        f"No BTX specs found for providers {_SUPPORTED_PROVIDERS} under {os.environ.get('BTX_SPEC_ROOT')}. "
+        "Check that the spec ref is correct and the spec repo contains the expected YAML files."
+    )
+
 # ---------------------------------------------------------------------------
 # Test
 # ---------------------------------------------------------------------------