Skip to content

Ambiguous assertions in the tests #8

@pgrt

Description

@pgrt

Hello,

While packaging version 1.1.0 of http-nio in Debian, I got test failures related to ambiguous assertions:

/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:75: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.runWithRetries(() -> 3), 3);
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:103: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:113: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:147: error: reference to assertEquals is ambiguous
Assert.assertEquals(DEFAULT_RETRY_HANDLER.tryOnceThenWithRetries(
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match
/<>/src/test/java/org/broadinstitute/http/nio/RetryHandlerUnitTest.java:176: error: reference to assertEquals is ambiguous
Assert.assertEquals(NO_RETRIES_HANDLER.runWithRetries(() -> 3), 3);
^
both method assertEquals(Object,Object) in Assert and method assertEquals(int,int) in Assert match

The enclosed patch fixes this.

Best,

Pierre

ambiguous_assertions.txt

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions