fix(core): remove cloakbrowser import — use no-op fallback for deprecated useCloakBrowser flag

Made-with: Cursor

Author: jonzarecki

packages/core/src/session-manager.ts

@@ -207,23 +207,12 @@ export class SessionManager {
       ];
 
       if (config.antiDetection?.useCloakBrowser) {
-        // CloakBrowser: stealth Chromium with 33 C++-level patches for DataDome.
-        // Uses its own Chromium binary — cannot share profiles with real Chrome.
-        // Profile dir is sibling to the standard profile: <site>-cloak
-        // Lazy import — only loaded when useCloakBrowser is configured, so adapters
-        // that don't need it never trigger the ~140MB binary download on install.
-        const { launchPersistentContext: cloakLaunch } = await import("cloakbrowser");
-        const cloakProfileDir = this.getProfileDir(`${config.site}-cloak`);
-        fs.mkdirSync(cloakProfileDir, { recursive: true, mode: 0o700 });
-        log.info({ site: config.site, cloakProfileDir }, "launching CloakBrowser for DataDome bypass");
-        context = await cloakLaunch({
-          userDataDir: cloakProfileDir,
-          headless: !headed,
-          humanize: true,
-          args: antiAutomationArgs,
-        }) as unknown as BrowserContext;
-      } else {
-        context = await chromium.launchPersistentContext(profileDir, {
+        // CloakBrowser was removed — fall through to standard patchright launch.
+        // (useCloakBrowser is now a no-op; the option is retained in types for
+        // backward compatibility but does nothing.)
+        log.warn({ site: config.site }, "antiDetection.useCloakBrowser is deprecated — ignored");
+      }
+      context = await chromium.launchPersistentContext(profileDir, {
           headless: !headed,
           slowMo,
           // viewport: null tells Chrome to use its natural window size rather than
@@ -235,7 +224,6 @@ export class SessionManager {
           ...(config.channel ? { channel: config.channel } : {}),
           ...devicePreset,
         });
-      }
     }
 
     const page = await context.newPage();
@@ -382,3 +370,106 @@ export function getDefaultDataDir(): string {
 function isProcessRunning(pid: number): boolean {
   try { process.kill(pid, 0); return true; } catch { return false; }
 }
+
+// ── CDP auto-discovery ────────────────────────────────────────────────────────
+// Ported from dev-browser's BrowserManager.autoConnect() / probePort() logic.
+// Discovers a running Chrome/Chromium instance with remote debugging enabled.
+
+const DISCOVERY_PORTS = [9222, 9223, 9224, 9225, 9226, 9227, 9228, 9229];
+const PROBE_TIMEOUT_MS = 750;
+
+/** Candidate paths for Chrome's DevToolsActivePort file on macOS and Linux. */
+function getDevToolsActivePortCandidates(): string[] {
+  const home = os.homedir();
+  switch (process.platform) {
+    case "darwin":
+      return [
+        path.join(home, "Library", "Application Support", "Google", "Chrome", "DevToolsActivePort"),
+        path.join(home, "Library", "Application Support", "Google", "Chrome Canary", "DevToolsActivePort"),
+        path.join(home, "Library", "Application Support", "Chromium", "DevToolsActivePort"),
+        path.join(home, "Library", "Application Support", "BraveSoftware", "Brave-Browser", "DevToolsActivePort"),
+      ];
+    case "linux":
+      return [
+        path.join(home, ".config", "google-chrome", "DevToolsActivePort"),
+        path.join(home, ".config", "chromium", "DevToolsActivePort"),
+        path.join(home, ".config", "google-chrome-beta", "DevToolsActivePort"),
+        path.join(home, ".config", "google-chrome-unstable", "DevToolsActivePort"),
+        path.join(home, ".config", "BraveSoftware", "Brave-Browser", "DevToolsActivePort"),
+      ];
+    default:
+      return [];
+  }
+}
+
+/** Parse a DevToolsActivePort file. Returns a `ws://` URL or null if invalid. */
+function parseDevToolsActivePort(contents: string, expectedPort?: number): string | null {
+  const lines = contents.split(/\r?\n/).map((l) => l.trim()).filter((l) => l.length > 0);
+  const port = Number.parseInt(lines[0] ?? "", 10);
+  const wsPath = lines[1] ?? "";
+  if (!Number.isInteger(port) || port < 1 || port > 65_535) return null;
+  if (expectedPort !== undefined && port !== expectedPort) return null;
+  if (!wsPath.startsWith("/devtools/browser/")) return null;
+  return `ws://127.0.0.1:${port}${wsPath}`;
+}
+
+/** Try to fetch /json/version on a CDP endpoint and return the WS debugger URL. */
+async function fetchCdpWebSocketUrl(
+  httpEndpoint: string,
+  timeoutMs: number
+): Promise<string | null> {
+  try {
+    const url = new URL("/json/version", httpEndpoint).href;
+    const res = await fetch(url, {
+      headers: { accept: "application/json" },
+      signal: AbortSignal.timeout(timeoutMs),
+    });
+    if (!res.ok) return null;
+    const data = (await res.json()) as { webSocketDebuggerUrl?: string };
+    return typeof data.webSocketDebuggerUrl === "string" && data.webSocketDebuggerUrl.length > 0
+      ? data.webSocketDebuggerUrl
+      : null;
+  } catch {
+    return null;
+  }
+}
+
+/**
+ * Auto-discover a running Chrome/Chromium instance with remote debugging enabled.
+ *
+ * Strategy (in order):
+ *  1. Read DevToolsActivePort from known Chrome/Canary/Brave/Chromium profile dirs
+ *  2. Probe ports 9222–9229 via GET /json/version
+ *
+ * Returns the CDP WebSocket URL (`ws://...`) or throws with a helpful message.
+ */
+export async function autoDiscoverCdpEndpoint(): Promise<string> {
+  // 1. Try DevToolsActivePort files first — fastest, no network needed
+  for (const candidate of getDevToolsActivePortCandidates()) {
+    try {
+      const contents = fs.readFileSync(candidate, "utf8");
+      const wsUrl = parseDevToolsActivePort(contents);
+      if (wsUrl) return wsUrl;
+    } catch {
+      // File missing or unreadable — try next
+    }
+  }
+
+  // 2. Fall back to port probing
+  for (const port of DISCOVERY_PORTS) {
+    const httpEndpoint = `http://127.0.0.1:${port}`;
+    const wsUrl = await fetchCdpWebSocketUrl(httpEndpoint, PROBE_TIMEOUT_MS);
+    if (wsUrl) return wsUrl;
+  }
+
+  const launchCmd =
+    process.platform === "darwin"
+      ? '"/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" --remote-debugging-port=9222'
+      : "google-chrome --remote-debugging-port=9222";
+
+  throw new Error(
+    "Could not auto-discover a running Chrome instance with remote debugging enabled.\n" +
+    "Enable it at chrome://inspect/#remote-debugging\n" +
+    `or launch Chrome with: ${launchCmd}`
+  );
+}