diff --git a/.jules/bolt.md b/.jules/bolt.md new file mode 100644 index 0000000..1586fe4 --- /dev/null +++ b/.jules/bolt.md @@ -0,0 +1,3 @@ +## 2024-07-08 - Bypass Cached Database Queries with Synchronous Compilation +**Learning:** When React's `cache()` wraps a data-fetching method (e.g., `getWorkspaceExperienceBySlug`), modifying its signature to accept optional pre-fetched objects fragments the cache. Furthermore, calling the cached method when the data (e.g., `Organization`) is already available results in redundant database queries. +**Action:** Instead of modifying the cached function, bypass it and directly call the internal synchronous compiler (e.g., `compileWorkspaceExperience`) from the application layer when the necessary data is already available, taking care not to reference properties (like `organization`) that are omitted from the compiler's return type. diff --git a/lib/application/auth/tenant-access-selection.ts b/lib/application/auth/tenant-access-selection.ts index 75e45ac..ffe475b 100644 --- a/lib/application/auth/tenant-access-selection.ts +++ b/lib/application/auth/tenant-access-selection.ts @@ -8,9 +8,9 @@ export interface MembershipSelectionOrganization { slug: string; } -export function selectMembershipOrganization(input: { +export function selectMembershipOrganization(input: { memberships: MembershipSelectionMember[]; - organizationsById: Map; + organizationsById: Map; requestedSlug?: string | null; }) { const requestedSlug = input.requestedSlug?.trim() || null; diff --git a/lib/application/auth/tenant-access.ts b/lib/application/auth/tenant-access.ts index 09f0d27..c988972 100644 --- a/lib/application/auth/tenant-access.ts +++ b/lib/application/auth/tenant-access.ts @@ -12,6 +12,7 @@ import { } from "@/lib/application/auth/tenant-routing"; import { selectMembershipOrganization } from "@/lib/application/auth/tenant-access-selection"; import { getWorkspaceExperienceBySlug } from "@/lib/application/workspace/workspace-service"; +import { compileWorkspaceExperience } from "@/lib/platform/workspace/compiler"; import { OrganizationMemberRepository } from "@/lib/infrastructure/supabase/organization-member-repository"; import { OrganizationRepository } from "@/lib/infrastructure/supabase/organization-repository"; import { resolveWorkspaceTemplateForEmailDomain } from "@/lib/platform/workspace/registry"; @@ -110,11 +111,11 @@ export async function resolveTenantAccess( }); if (organization) { - const workspace = await getWorkspaceExperienceBySlug(organization.slug); + const compiled = compileWorkspaceExperience({ slug: organization.slug, organization }); return existingWorkspaceAccess({ slug: organization.slug, name: organization.name, - workspace: workspace.workspace, + workspace: compiled.workspace, accessMethod: "membership", }); } @@ -124,11 +125,11 @@ export async function resolveTenantAccess( if (emailDomain) { const workspaceOrganization = await organizations.findFirstByWorkspaceEmailDomain(emailDomain); if (workspaceOrganization && (!requestedSlug || workspaceOrganization.slug === requestedSlug)) { - const workspace = await getWorkspaceExperienceBySlug(workspaceOrganization.slug); + const compiled = compileWorkspaceExperience({ slug: workspaceOrganization.slug, organization: workspaceOrganization }); return existingWorkspaceAccess({ slug: workspaceOrganization.slug, name: workspaceOrganization.name, - workspace: workspace.workspace, + workspace: compiled.workspace, accessMethod: "domain_template", }); } @@ -143,11 +144,11 @@ export async function resolveTenantAccess( if (guessed.slug) { const existingOrganization = await organizations.findBySlug(guessed.slug).catch(() => null); if (existingOrganization) { - const workspace = await getWorkspaceExperienceBySlug(existingOrganization.slug); + const compiled = compileWorkspaceExperience({ slug: existingOrganization.slug, organization: existingOrganization }); return existingWorkspaceAccess({ slug: existingOrganization.slug, name: existingOrganization.name, - workspace: workspace.workspace, + workspace: compiled.workspace, accessMethod: "domain_template", }); }