Skip to content

feat(runtime): align raw context AToB intrinsic#743

Merged
buke merged 1 commit into
mainfrom
feat/raw-context-atob
May 22, 2026
Merged

feat(runtime): align raw context AToB intrinsic#743
buke merged 1 commit into
mainfrom
feat/raw-context-atob

Conversation

@buke
Copy link
Copy Markdown
Owner

@buke buke commented May 22, 2026

  • add an AToB option to raw-context intrinsic selection
  • wire JS_AddIntrinsicAToB into applyIntrinsics and AllIntrinsics
  • cover raw-context AToB behavior and failure hooks in runtime tests

- add an AToB option to raw-context intrinsic selection
- wire JS_AddIntrinsicAToB into applyIntrinsics and AllIntrinsics
- cover raw-context AToB behavior and failure hooks in runtime tests
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (f04fc26) to head (c434927).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #743   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         3705      3709    +4     
=========================================
+ Hits          3705      3709    +4     
Files with missing lines Coverage Δ
runtime.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f04fc26...c434927. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for atob and btoa intrinsics in the runtime. It adds an AToB option to the IntrinsicSet, provides a WithAToB configuration function, and updates the intrinsic application logic to include the new functionality. Comprehensive tests were added to verify the behavior of these intrinsics when enabled or disabled, including error handling scenarios. I have no feedback to provide.

@buke buke merged commit 7e815f2 into main May 22, 2026
8 checks passed
@buke buke deleted the feat/raw-context-atob branch May 22, 2026 06:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant