fix(runtime): align module loader and strip option semantics#747
Conversation
buke
commented
May 22, 2026
- make SetModuleImport install or clear the default file module loader
- mark SetStripInfo and WithStripInfo as compatibility no-ops
- add runtime tests for module import toggling and refresh README wording
- make SetModuleImport install or clear the default file module loader - mark SetStripInfo and WithStripInfo as compatibility no-ops - add runtime tests for module import toggling and refresh README wording
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #747 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 17 17
Lines 3723 3726 +3
=========================================
+ Hits 3723 3726 +3
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
This pull request updates the module loading mechanism and deprecates strip-info functionality to align with quickjs-ng. Specifically, SetModuleImport now correctly toggles the default file-based module loader using a write lock, and WithStripInfo and SetStripInfo are marked as deprecated no-ops. Documentation and README examples were updated to reflect these changes, and new tests were added to verify the module import toggling. I have no feedback to provide.