Skip to content

fix(runtime): align module loader and strip option semantics#747

Merged
buke merged 1 commit into
mainfrom
fix/runtime-pr1-semantics
May 22, 2026
Merged

fix(runtime): align module loader and strip option semantics#747
buke merged 1 commit into
mainfrom
fix/runtime-pr1-semantics

Conversation

@buke
Copy link
Copy Markdown
Owner

@buke buke commented May 22, 2026

  • make SetModuleImport install or clear the default file module loader
  • mark SetStripInfo and WithStripInfo as compatibility no-ops
  • add runtime tests for module import toggling and refresh README wording

- make SetModuleImport install or clear the default file module loader
- mark SetStripInfo and WithStripInfo as compatibility no-ops
- add runtime tests for module import toggling and refresh README wording
@codecov
Copy link
Copy Markdown

codecov Bot commented May 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (c0c659d) to head (c798d72).

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #747   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           17        17           
  Lines         3723      3726    +3     
=========================================
+ Hits          3723      3726    +3     
Files with missing lines Coverage Δ
runtime.go 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0c659d...c798d72. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the module loading mechanism and deprecates strip-info functionality to align with quickjs-ng. Specifically, SetModuleImport now correctly toggles the default file-based module loader using a write lock, and WithStripInfo and SetStripInfo are marked as deprecated no-ops. Documentation and README examples were updated to reflect these changes, and new tests were added to verify the module import toggling. I have no feedback to provide.

@buke buke merged commit d586cac into main May 22, 2026
8 checks passed
@buke buke deleted the fix/runtime-pr1-semantics branch May 22, 2026 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant