Firmware build fails on latest QMK

[gyvess]

I just built the lastest qmk_firmware from git to give high resolution scrolling a shot, but building the firmware is now stopped by this error caused by maccel.

 #define CONSTRAIN_REPORT(val) (mouse_xy_report_t) _CONSTRAIN(val, XY_REPORT_MIN, XY_REPORT_MAX)
                                                                   ^~~~~~~~~~~~~
maccel.c:102:46: note: in definition of macro ‘_CONSTRAIN’
 #define _CONSTRAIN(amt, low, high) ((amt) < (low) ? (low) : ((amt) > (high) ? (high) : (amt)))
                                              ^~~
maccel.c:153:33: note: in expansion of macro ‘CONSTRAIN_REPORT’
     const mouse_xy_report_t x = CONSTRAIN_REPORT(new_x);
                                 ^~~~~~~~~~~~~~~~
maccel.c:103:67: note: each undeclared identifier is reported only once for each function it appears in
 #define CONSTRAIN_REPORT(val) (mouse_xy_report_t) _CONSTRAIN(val, XY_REPORT_MIN, XY_REPORT_MAX)
                                                                   ^~~~~~~~~~~~~
maccel.c:102:46: note: in definition of macro ‘_CONSTRAIN’
 #define _CONSTRAIN(amt, low, high) ((amt) < (low) ? (low) : ((amt) > (high) ? (high) : (amt)))
                                              ^~~
maccel.c:153:33: note: in expansion of macro ‘CONSTRAIN_REPORT’
     const mouse_xy_report_t x = CONSTRAIN_REPORT(new_x);
                                 ^~~~~~~~~~~~~~~~
maccel.c:103:82: error: ‘XY_REPORT_MAX’ undeclared (first use in this function)
 #define CONSTRAIN_REPORT(val) (mouse_xy_report_t) _CONSTRAIN(val, XY_REPORT_MIN, XY_REPORT_MAX)
                                                                                  ^~~~~~~~~~~~~
maccel.c:102:71: note: in definition of macro ‘_CONSTRAIN’
 #define _CONSTRAIN(amt, low, high) ((amt) < (low) ? (low) : ((amt) > (high) ? (high) : (amt)))
                                                                       ^~~~
maccel.c:153:33: note: in expansion of macro ‘CONSTRAIN_REPORT’
     const mouse_xy_report_t x = CONSTRAIN_REPORT(new_x);
                                 ^~~~~~~~~~~~~~~~
 [ERRORS]

[ArijanJ]

#    define XY_REPORT_MIN INT16_MIN
#    define XY_REPORT_MAX INT16_MAX

With these definitions in maccel.c (and extended mouse reports) it seems to work, although there are bigger problems with maccel_via so you won't be able to use it until @burkfers updates it 🥺 (looks like api changes for the eeconfig_.._datablock functions with recent qmk?)

[gyvess]

Instead, try changing line 103 of maccel.c to this.
#define CONSTRAIN_REPORT(val) (mouse_xy_report_t) _CONSTRAIN(val, MOUSE_REPORT_XY_MIN, MOUSE_REPORT_XY_MAX)

It changes the former variable names to the now appropriate ones.

[burkfers]

This repo is now considered obsolete. Please see https://github.com/drashna/qmk_modules/tree/main/pointing_device_accel for an improved version brought up to date and with simplified installation leveraging QMK's new Community Modules feature. It's still the same under the hood, so it'll work just like you're used to!