Remove or restrict exports of `internal` packages in `module-info`

[Marcono1234]

Currently some module-info.java files export internal packages:

• endive/compiler/src/main/java/module-info.java

  Line 9 in 7505798

  exports run.endive.compiler.internal;

• endive/runtime/src/main/java/module-info.java

  Line 6 in 7505798

  exports run.endive.runtime.internal;

This defeats the purpose of the module declaration a bit, and the mere presence of the word "internal" in the package name is not sufficient to prevent users from relying on it, possibly even by accident due to IDE completion suggestions.

If possible it would be good to remove those exports or to restrict them by using exports <package> to <module> (documentation) to sibling Endive modules which are allowed to use the internal packages.

It seems exporting the internal packages was intentional, see dylibso/chicory#1028 (comment) and dylibso/chicory#1028 (comment), but not sure if those concerns still apply.

It seems for Chicory there are some third-party users of the internal API (based on GitHub search; might be incomplete):

• https://github.com/dzbarsky/wasm-repro/blob/daf71f032c547ebc4fc673e99628485f00b7efcc/java/src/main/java/org/acme/Toml2Json.java#L7
  (actually unused import?)
• https://github.com/chirino/wasm-dwarf-parser/blob/5a9ced302113e0dc9eea62c20bf77935f3677f28/src/test/java/io/github/chirino/wasm/dwarf/rust/RustParserTest.java#L8
• https://github.com/roastedroot/chicory-redline/blob/e1160a69d831bfb1da6ef90d5dfb9ecc3d369fa5/build-time-compiler/src/main/java/io/roastedroot/redline/build/Generator.java#L12-L13
  (maybe obsolete if Redline is integrated here? or can be worked around using exports ... to if the usage of internal API is accepted there)
• https://github.com/boredhuman/JavaGraphicsTools/blob/06857366f31cd80032a13722b8aaec1a7307778e/codegen/src/main/java/dev/boredhuman/codegen/internal/CodeGenMain.java#L3

[andreaTP]

Thanks for taking the time to file this issue @Marcono1234 !

It seems for Chicory there are some third-party users of the internal API (based on GitHub search; might be incomplete):

None of the examples is actual user code, they are either experiments/hacks and similar, and yes, I'm working on including redline in this codebase.

If possible it would be good to remove those exports or to restrict them by using exports to (documentation) to sibling Endive modules which are allowed to use the internal packages.

Seems legit, but I'm not sure what it imply. Would you be up sending over a proposal? 🙂