fix(javascript): enableNpm option have been removed from nixpkgs#2540
Closed
shikanime wants to merge 1 commit into
Closed
fix(javascript): enableNpm option have been removed from nixpkgs#2540shikanime wants to merge 1 commit into
shikanime wants to merge 1 commit into
Conversation
Member
|
we need to check if it supports the parameter and still call it if it does to support old nixpkgs |
Fixes: cachix#2538 Signed-off-by: William Phetsinorath <william.phetsinorath@shikanime.studio> Change-Id: I3f64d53a63ef26dd285c3575276f10686a6a6964
Contributor
Author
|
@domenkozar done 👍 |
Contributor
Author
|
Thinking about it, npm should not even exist anymore at this point. |
Member
|
Fixed in 6da2445. @shikanime, sorry for sniping this one from you, but I needed a quickfix after bumping devenv-nixpkgs. One issue with the PR here is that default args don't show up in the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #2538
Signed-off-by: William Phetsinorath william.phetsinorath@shikanime.studio
Change-Id: I3f64d53a63ef26dd285c3575276f10686a6a6964